Remove a special case in table deleteTextHandler#5891
Merged
ivailop7 merged 2 commits intofacebook:mainfrom Apr 16, 2024
Merged
Remove a special case in table deleteTextHandler#5891ivailop7 merged 2 commits intofacebook:mainfrom
ivailop7 merged 2 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Hi! Thanks for this fix! Do you think we can write a test for it? |
zurfyx
previously approved these changes
Apr 15, 2024
Contributor
Author
Sure! d95d99f |
potatowagon
approved these changes
Apr 16, 2024
| `, | ||
| ); | ||
| }); | ||
|
|
ivailop7
approved these changes
Apr 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #3213 but wasn't cleaned up after a proper fix.
Currently this does not allow the removal of empty lines in a collapsible section inside of a table.
Before:
After:
