Refine backspace handling in Tables#3213
Merged
tylerjbainbridge merged 3 commits intomainfrom Oct 19, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c48ad58 to
5466421
Compare
zurfyx
approved these changes
Oct 18, 2022
Member
zurfyx
left a comment
There was a problem hiding this comment.
Makes sense, let's ship the workaround for now and investigate the long-term fix more carefully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch. The real solution is to refine the way selection is modified after hitting backspace. The focus should not be moved to a node with a different
shadowRoot, but right now this is how native domSelection works.Before:
Screen.Recording.2022-10-18.at.4.05.36.PM.mov
After:
Screen.Recording.2022-10-18.at.4.05.08.PM.mov