Skip to content

TextNode support font-weight bold#5852

Merged
zurfyx merged 1 commit intomainfrom
font-weight-bold2
Apr 11, 2024
Merged

TextNode support font-weight bold#5852
zurfyx merged 1 commit intomainfrom
font-weight-bold2

Conversation

@zurfyx
Copy link
Copy Markdown
Member

@zurfyx zurfyx commented Apr 9, 2024 •
edited
Loading

Turns out that Google Spreadsheets can return bold text in font-weight=bold that we weren't handling yet.

Screenshot 2024-04-09 at 12 26 47 PM 
<span
  style="font-size:10pt;font-family:Arial;font-style:normal;">df </span><span
  style="font-size:10pt;font-family:Arial;font-weight:bold;font-style:normal;">dasdf</span>

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 9, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview Apr 9, 2024 4:29am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 4:29am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (+0.02% 🔺) 540 ms (+0.02% 🔺) 148 ms (-12.46% 🔽) 687 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (+0.01% 🔺) 788 ms (+0.01% 🔺) 575 ms (+27.87% 🔺) 1.4 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (+0.02% 🔺) 787 ms (+0.02% 🔺) 549 ms (+17.71% 🔺) 1.4 s

Sahejkm
Sahejkm approved these changes Apr 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zurfyx zurfyx merged commit 70c785e into main Apr 11, 2024
@zurfyx zurfyx deleted the font-weight-bold2 branch April 11, 2024 00:22
zurfyx added a commit that referenced this pull request Apr 11, 2024
@zurfyx
Revert "TextNode support font-weight bold (#5852)"
f0877b5 
This reverts commit 70c785e.
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StyleT StyleT StyleT approved these changes

@ivailop7 ivailop7 ivailop7 approved these changes

@Sahejkm Sahejkm Sahejkm approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zurfyx @StyleT @ivailop7 @Sahejkm @facebook-github-bot