Add a setter for the format property on RangeSelection#5829
Merged
etrepum merged 3 commits intofacebook:mainfrom Jul 6, 2025
Merged
Add a setter for the format property on RangeSelection#5829etrepum merged 3 commits intofacebook:mainfrom
etrepum merged 3 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Where's the code that calls this setter? |
Contributor
Author
|
This addition is more of an api enhancement (exactly like However, this addition provides a safe way for developers to update the format property without unexpected side-effects, namely from forgetting to set the |
size-limit report 📦
|
ivailop7
approved these changes
Jul 6, 2025
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a setter method for the format property within the RangeSelection class. This enhancement aims to simplify the process of updating the format for range selections within the API.
Changes Made:
This method allows developers to modify the format of the range selection in a more intuitive manner, eliminating the need to directly manipulate the format property.
Benefits
Improves code readability and maintainability by providing a clear and consistent interface for modifying the format property.
Reduces the likelihood of errors and misuse by encapsulating the logic for setting format values within a dedicated method.