Skip to content

Fix failing WWW build#5826

Merged
thegreatercurve merged 1 commit intomainfrom
bug/www-build
Apr 4, 2024
Merged

Fix failing WWW build#5826
thegreatercurve merged 1 commit intomainfrom
bug/www-build

Conversation

@thegreatercurve
Copy link
Copy Markdown
Contributor

@thegreatercurve thegreatercurve commented Apr 4, 2024 •
edited
Loading

Fix failing WWW build by re-writing imports. This naturally aren't being tree-shaken since #5774

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 10:04am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 10:04am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.77 KB (0%) 536 ms (0%) 201 ms (+40.77% 🔺) 736 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.01 KB (0%) 781 ms (0%) 478 ms (+6.54% 🔺) 1.3 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.98 KB (0%) 780 ms (0%) 407 ms (-0.1% 🔽) 1.2 s

@thegreatercurve thegreatercurve marked this pull request as ready for review April 4, 2024 10:11
@thegreatercurve thegreatercurve merged commit 6558e22 into main Apr 4, 2024
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
@zurfyx zurfyx deleted the bug/www-build branch February 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thegreatercurve @ivailop7 @facebook-github-bot