Node fork modules & moduleResolution bundler#5774
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
0636b4f to
0fe0397
Compare
0fe0397 to
314077d
Compare
314077d to
cc6c3fe
Compare
caecbbb to
d6253c9
Compare
|
@2wheeh I'll take a look at that test, but not sure how successful I will be at reproducing it since I'm on macOS |
|
@etrepum Thanks. I was not able to reproduce for the same reason as well... |
|
I suspect these are just bad e2e tests that are failing because something about firefox is slower (maybe due to y-websocket!), I did manage to fire up an old gaming pc and install node to run these tests and they fail locally but the chromium ones succeed. This sort of test code looks particularly suspicious: test('Can autocomplete a word', async ({page, isPlainText}) => {
await focusEditor(page);
await page.keyboard.type('Sort by alpha');
await sleep(500);
await assertHTML(...); |
There was a problem hiding this comment.
These are quite pervasive changes, need @acywatson @zurfyx @fantactuka as well, especially for the y-websocket ones. The plan is still to potentially merge before end of next week, since I'm planning on doing another release next friday.
|
I think that #5788 should address the problems with the collab tests 🤞 |
Create a separate set of esm fork modules specifically for node that use top-level await. These should work with node >= 14.8 (for SSR) but not cause problems for bundlers that can't handle them.
The reason to do this would be to save a bit of startup time and memory when running Lexical directly in a Node.js environment (SSR, headless, etc.). Otherwise, since tree-shaking isn't done when executing directly, both dev and prod get loaded.
Closes #5716 (those commits are cherry-picked into here)
Fixes #5710 via #5716
Fixes #5117 via #5716
Fixes #4160 via #5716
Fixes #5783 (removes inter-package monorepo peerDependencies)