Skip to content

Regression tests for #379#381

Merged
trueadm merged 4 commits intomainfrom
379-backspace-with-mentions
Jun 15, 2021
Merged

Regression tests for #379#381
trueadm merged 4 commits intomainfrom
379-backspace-with-mentions

Conversation

@prontiol
Copy link
Copy Markdown
Contributor

@prontiol prontiol commented Jun 15, 2021

No description provided.

@trueadm trueadm force-pushed the 379-backspace-with-mentions branch from f3e4a6e to 1dc0cb9 Compare June 15, 2021 12:30
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2021
@trueadm
Copy link
Copy Markdown
Collaborator

trueadm commented Jun 15, 2021

I made some fixes to the test:

  • Used the helper function rather than using "End", as "End" doesn't work properly on Macs.
  • Opted to use Luke Skywalker, as FF selects the wrong result half the time as other matches start with "Y".
  • Cleaned up the HTML output a bit.

@trueadm trueadm merged commit d6a9528 into main Jun 15, 2021
@trueadm trueadm deleted the 379-backspace-with-mentions branch June 15, 2021 12:50
@prontiol prontiol linked an issue Jun 29, 2021 that may be closed by this pull request
Bug: incorrect backspace behavior in paragraphs with mentions #379
Closed
acywatson pushed a commit that referenced this pull request Apr 9, 2022
@prontiol @trueadm @acywatson
Regression tests for #379 (#381)
4e635ce 
* Regression tests for #379

* Remove BOM character from test

* Tweak test

* Fix test for Macs that dont use End

Co-authored-by: Dominic Gannaway <dg@domgan.com>
Co-authored-by: Dominic Gannaway <trueadm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: incorrect backspace behavior in paragraphs with mentions

3 participants

@prontiol @trueadm @facebook-github-bot