Add JSXText node definition#80
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom May 12, 2017
Merged
Conversation
Contributor
Author
|
@vjeux @sebmarkbage I used the node type that is used in Flow and ESprima parsers. Babylon does not use the |
Contributor
|
Babylon now has the |
hzoo
pushed a commit
to babel/babel
that referenced
this pull request
Mar 15, 2018
`JSXText` was added to the JSX spec [here](facebook/jsx#80).
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
`JSXText` was added to the JSX spec [here](facebook/jsx#80).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent change #78 allowed JSXText nodes to be used as a child in JSXElement but did not define the JSXText node. This commits adds a definition for JXText.
We might want to define exactly what is the difference between the property
rawandvalueor leave it up to parsers to decided. I believe currently esprima and flow convert CRLF line ending for thevalueproperty but leave the text as is in therawproperty.