Merged
Conversation
Contributor
|
I've had similar problems before, but I ended up going with |
Contributor
|
@zertosh it was added mainly as a convenience. I think jscodeshift should provide a reasonable default. |
Contributor
|
Fair enough! |
Contributor
|
One issue with |
euphocat
pushed a commit
to euphocat/jscodeshift
that referenced
this pull request
Oct 22, 2017
* Add first pass of supporting es6 imports in react-to-react-dom * Add tests for es6 imports in react-to-react-dom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement the function
dir.filesthat walks directories to collect files.The main change is that when stat problems are encountered (e.g., due to symlink issues), we log an error but continue on, instead of refusing to any work.