Add restricted properties to function prototype#1117
Closed
fbmal7 wants to merge 2 commits into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48205935 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48205935 |
Summary: `uint64_t` is not a well supported type for `llvh::cl::opt`. Change it to `unsigned` instead. Differential Revision: D49202751 fbshipit-source-id: 9ca338520e1627445ba838558a9be742e96759f6
Summary: Pull Request resolved: #1117 Move `caller` and `arguments` throwing accessors onto Function.prototype. Define these unconditionally, not just in strict mode. This is in accordance with [AddRestrictedFunctionProperties](https://tc39.es/ecma262/#sec-addrestrictedfunctionproperties). Reviewed By: avp Differential Revision: D48205935 fbshipit-source-id: 7ca3ff4fe8795d926ba08530b9d3b96ebdec856b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48205935 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: #1117 Move `caller` and `arguments` throwing accessors onto Function.prototype. Define these unconditionally, not just in strict mode. This is in accordance with [AddRestrictedFunctionProperties](https://tc39.es/ecma262/#sec-addrestrictedfunctionproperties). Reviewed By: avp Differential Revision: D48205935 fbshipit-source-id: 25585ce4117ec320a2c1032208c55b8b8e860795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
callerandargumentsthrowing accessors ontoFunction.prototype. Define these unconditionally, not just in strict
mode. This is in accordance with AddRestrictedFunctionProperties.
Reviewed By: avp
Differential Revision: D48205935