fix: collapse siblings when first category is selected#7786
Merged
Conversation
Josh-Cena
approved these changes
Jul 15, 2022
Josh-Cena
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Makes sense to me...
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
pushed a commit
that referenced
this pull request
Sep 1, 2022
fix: not collapsing when first category is selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When clicking on first section other section will not collapse.
Test Plan
expandedItemwhen it is equal to0is a falsy value. Therefore thatuseEffectwill not produce any effect. I've changed it to checking ofexpandedItem != nullin order to ensure that effect will not happen only when expanded item isnullorundefined.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
There is none