chore: add missing v1 generated files to ignores#3872
Merged
slorber merged 1 commit intofacebook:masterfrom Dec 3, 2020
Merged
chore: add missing v1 generated files to ignores#3872slorber merged 1 commit intofacebook:masterfrom
slorber merged 1 commit intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 62e0c35 |
|
Size Change: 0 B Total Size: 157 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@slorber reported that after latest changes to ignores two generated files from v1 build are marked as
unversioned. This PR fix that issue by adding the files to ignores.Earlier they were part of removed
.gitignorefrom v1 package.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
V1 build locally and run of
git ls-files . --exclude-standard --others,yarn prettierandyarn lint.Related PRs