chore(v2): fix ignore paths and Prettier commands in themes#3865
chore(v2): fix ignore paths and Prettier commands in themes#3865slorber merged 3 commits intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 22b8a4e |
|
Size Change: +18 B (0%) Total Size: 157 kB ℹ️ View Unchanged
|
.prettierignore
Outdated
| packages/docusaurus/lib/ | ||
| packages/docusaurus-init/lib/ | ||
| packages/docusaurus-plugin-client-redirects/lib/ | ||
| packages/docusaurus-*/lib/ |
There was a problem hiding this comment.
I think it won't work for the v1 package? (uncompiled nodejs code)
There was a problem hiding this comment.
For this is responsible .gitignore, which do not include v1 lib. I can update .gitignore too.
There was a problem hiding this comment.
Ah, you mean the change should NOT exclude the files from v1 lib, right?
There was a problem hiding this comment.
This line in ignores deals with that, so Prettier and other tools will ignore all docusuaurs-*/libs but not the docusuaurs-1.x/lib.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3865--docusaurus-2.netlify.app/classic/ |
Motivation
It looks like after latest addition of
lib-nextand some other changes Prettier started to format unnecessary files.This PR rewrites the
.prettierignorepath into more universal format and adds--ignore-pathflag to the Prettier command in themes, so the ignores defined in.prettierignoreare respected.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Local run of:
yarn prettieryarn --cwd ./packages/docusaurus-theme-bootstrap buildyarn lintRelated PRs
No.