fix(v2): fix DocSearch keyboard navigator#3853
Merged
slorber merged 5 commits intofacebook:masterfrom Dec 1, 2020
Merged
Conversation
|
Deploy preview for docusaurus-2 ready! Built with commit 4a1ce2f |
|
Size Change: 0 B Total Size: 157 kB ℹ️ View Unchanged
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3853--docusaurus-2.netlify.app/classic/ |
Collaborator
|
thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes the keyboard navigation integration with Docusaurus following breaking changes in the Autocomplete API (which is an underlying library of DocSearch).
You'll now be able to hit Enter to be redirected to the link, as you were before.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
N/A.
Related PRs