feat(search): update DocSearch to alpha.31#3819
Merged
lex111 merged 2 commits intofacebook:masterfrom Nov 25, 2020
Merged
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit e30277c |
Collaborator
|
thanks almost LGTM but it looks like the shortcut key is not visible anymore for me (macos/chrome 87)
|
Contributor
Author
lex111
approved these changes
Nov 25, 2020
Contributor
|
@francoischalifour thanks! |
Collaborator
|
@francoischalifour thanks was wondering if you could make the search input keep a constant size, with or without the keys in the search input? As we are using SSR, having things changing size just after hydration can somehow be considered as a layout shift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This updates the DocSearch version that includes a few fixes and new features:
This version displays are React development warning when using React 16 about the
enterKeyHintproperty that's officially supported from React 17: facebook/react#18634.You won't see this message from React 17.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
N/A.
Related PRs
N/A.