feat: push keyboard buttons till client#983
Merged
francoischalifour merged 2 commits intoalgolia:nextfrom Nov 5, 2020
maraisr:windows-support
Merged
feat: push keyboard buttons till client#983francoischalifour merged 2 commits intoalgolia:nextfrom maraisr:windows-support
francoischalifour merged 2 commits intoalgolia:nextfrom
maraisr:windows-support
Conversation
francoischalifour
approved these changes
Nov 5, 2020
Contributor
francoischalifour
left a comment
There was a problem hiding this comment.
Thank you for taking the time to tackle this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the issue around flickering buttons when we hydrate and on the client to figure out we're not on Mac.
This PR also aims to make the build flow compatible for windows developers, removing the
rm -rfand environment things to use npm proxy scripts, bothcross-envandrimrafare 2 very popular libraries for this.fixes: facebook/docusaurus#3682