Accept new data format passed from the binary#63
Merged
sf-wind merged 12 commits intofacebook:masterfrom Jul 19, 2018
Merged
Conversation
…r binaries may reuse the same parsing routine to extract the data
…ifferent mechanism to calculate the number of collected runs
| getLogger().info( | ||
| "No new items collected, finish collecting...") | ||
| return False | ||
| return valid_runs |
Contributor
There was a problem hiding this comment.
You may return "total_num" to stop the loop.
Contributor
Author
There was a problem hiding this comment.
You are right, should return total_num
Contributor
Author
There was a problem hiding this comment.
You are right, should return total_num
lly-zero-one
approved these changes
Jul 19, 2018
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 23, 2018
#9555) Summary: This is to simplify the data format during benchmarking. After this change, we can use the same benchmarking harness data conversion method to parse data from multiple binaries. This change should be coordinated with the PR: facebook/FAI-PEP#63 Pull Request resolved: #9555 Reviewed By: pjh5 Differential Revision: D8903024 Pulled By: sf-wind fbshipit-source-id: 61cabcff99f0873729142ec6cb6dc230c685d13a
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
pytorch#9555) Summary: This is to simplify the data format during benchmarking. After this change, we can use the same benchmarking harness data conversion method to parse data from multiple binaries. This change should be coordinated with the PR: facebook/FAI-PEP#63 Pull Request resolved: pytorch#9555 Reviewed By: pjh5 Differential Revision: D8903024 Pulled By: sf-wind fbshipit-source-id: 61cabcff99f0873729142ec6cb6dc230c685d13a
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
pytorch#9555) Summary: This is to simplify the data format during benchmarking. After this change, we can use the same benchmarking harness data conversion method to parse data from multiple binaries. This change should be coordinated with the PR: facebook/FAI-PEP#63 Pull Request resolved: pytorch#9555 Reviewed By: pjh5 Differential Revision: D8903024 Pulled By: sf-wind fbshipit-source-id: 61cabcff99f0873729142ec6cb6dc230c685d13a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data format is updated to be very general. After this change, multiple binaries can generate the same data format and use the same method to parse the data.