Fix MakeViewVariableOptionalSolution to disallow stream wrappers and files that do not end in .blade.php#334
Merged
freekmurze merged 5 commits intofacade:masterfrom Nov 17, 2020
Conversation
freekmurze
requested changes
Nov 17, 2020
Collaborator
|
Thanks! |
|
CVE-2021-3129 was assigned to this PR. |
|
Can we get this patch committed to the 1.16.x branch? |
|
I would love to create a PR myself with the changes for the 1.16.4 release, but unfortunately everything lives in the same branch (both 2.x and 1.x versions of this package). It would be fantastic if there was a way to push these changes to a 1.16.5 tag, so all the folks still using Laravel 6 and facade/ignition 1.x could benefit of this change. |
anasmirza534
added a commit
to anasmirza534/ignition
that referenced
this pull request
Feb 18, 2021
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
AlexVanderbist
added a commit
that referenced
this pull request
Mar 8, 2021
particleflux
added a commit
to particleflux/security-advisories
that referenced
this pull request
Mar 26, 2021
The vulnerability in `facade/ignition` is falsely reported for version 2.4.2. It has been fixed in facade/ignition#334 for 2.5.x, and in facade/ignition#356 for 2.4.x.
particleflux
added a commit
to particleflux/security-advisories
that referenced
this pull request
Mar 26, 2021
The vulnerability in `facade/ignition` is falsely reported for version 2.4.2. It has been fixed in facade/ignition#334 for 2.5.x, and in facade/ignition#356 for 2.4.x. Fixes FriendsOfPHP#543
lisadeloach63
pushed a commit
to lisadeloach63/laravel-ignition-error-page
that referenced
this pull request
Sep 1, 2022
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade/ignition#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
sadafrangian3
added a commit
to sadafrangian3/laravel-ignition
that referenced
this pull request
Apr 6, 2023
…files that do not end in .blade.php This is already fixed in 2.5.2, See facade/ignition#334 I could not update to 2.5.2 due to some dependent package required php 7.3, currently clients site is running in php 7.2 On branch 2.4.1-branch Changes to be committed: modified: src/Solutions/MakeViewVariableOptionalSolution.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, as discussed by email, this fixes a serious vulnerability.
Hopefully my code is OK-ish.