Closed
Conversation
fabpot
pushed a commit
that referenced
this pull request
Jul 30, 2023
fabpot
pushed a commit
that referenced
this pull request
Jul 30, 2023
…(iluuu1994) This PR was merged into the 2.0-dev branch. Discussion ---------- Fix BinaryFileResponse with range to psr response conversion Closes #84 As requested by [Fabien](symfony#38280 (comment)). I think using the slightly less optimal version of checking for a `Content-Range` header is better than relying on reflection. In theory, this could be slightly sub optimal when streaming whole files and setting the `Content-Range` manually but I'm assuming that's very rare in practice. Commits ------- 5d5932d Fix BinaryFileResponse with range to psr response conversion
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pull request was not taking care of HybridField, so I closed it and made a new one.