Skip to content

[DoctrineBundle] fixed doctrine.orm configuration#68

Closed
immutef wants to merge 10 commits intofabpot:masterfrom
immutef:master
Closed

[DoctrineBundle] fixed doctrine.orm configuration#68
immutef wants to merge 10 commits intofabpot:masterfrom
immutef:master

Conversation

@immutef
Copy link
Copy Markdown

@immutef immutef commented Oct 13, 2010

Fixed ignoring configuration options set to false.

This prevented anybody to disable auto_generate_proxy_classes,
for example (see doctrine:ensure-production-settings task).

@henrikbjorn
Copy link
Copy Markdown

wouldnt setting auto_generate_proxy_classes to false do the trick ?

@immutef
Copy link
Copy Markdown
Author

immutef commented Oct 13, 2010

isset() returns false if this setting is set to false, so this "trick" won't work.

@fabpot
Copy link
Copy Markdown
Owner

fabpot commented Oct 20, 2010

Can you make a branch for just that change. As is, I cannot see what you changed and what need to be merged.

@immutef
Copy link
Copy Markdown
Author

immutef commented Oct 20, 2010

Yeah, I totally messed up with GitHub pull requests, sorry for that. I'll redo everything and create dedicated branches and open new pull requests for everything. Thank you for clarification. I close this one.

fabpot pushed a commit that referenced this pull request Jul 30, 2023
This PR was merged into the 1.3-dev branch.

Discussion
----------

Use adapter for UploadedFile objects

Replaces #68, fixes #15, #39

Commits
-------

a4f9f6d Use adapter for UploadedFile objects
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants