Closed
Conversation
get($key, $first = true) not the same as ParameterBag get signature (for server attribute) get($key, $default = null) - remove port number from HOST header. To be consistent with backup values (SERVER_NAME, SERVER_ADDR). fix a problem with getUriForPath($path) where port number may be present twice.
Owner
|
I'd rather change the HeaderBag::get($key, $first = true) signature to HeaderBag::get($key, $default = null, $first = true). Can you update your patch? Thanks. |
Author
|
Shall i update HeaderBag class too ? |
Owner
|
yes |
Author
|
Created a new pull request . see 122 |
fabpot
pushed a commit
that referenced
this pull request
Jul 30, 2023
…ody (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- Don't rely on Request::getPayload() to populate the parsed body That's just not needed and creates issues like #121 + fixes a bug with invalid jsons. Commits ------- ef03b6d Don't rely on Request::getPayload() to populate the parsed body
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get($key, $first = true)
not the same as ParameterBag get signature (for server attribute)
get($key, $default = null)
fix a problem with getUriForPath($path) where port number may be present twice.