Support for stronger algorithms in MessageDigestEncoder#102
Closed
schmittjoh wants to merge 2 commits intofabpot:masterfrom
Closed
Support for stronger algorithms in MessageDigestEncoder#102schmittjoh wants to merge 2 commits intofabpot:masterfrom
schmittjoh wants to merge 2 commits intofabpot:masterfrom
Conversation
Author
|
I've considered the constructor as well, but then the entire constructor will need to be copy/pasted when overriding, just to get rid of the exception. You really want that? :) |
Owner
|
You are right. pushed. thanks. |
fabpot
pushed a commit
that referenced
this pull request
Jul 30, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements support for stronger / more modern algorithms by the use of the hash() function. It also replaces sha1 with sha256 as default algorithm.
See also http://groups.google.com/group/symfony-devs/browse_thread/thread/cfba48ca5c4f756b for reasoning.
If there are any code style errors, I'll be happy to fix them. Unfortunately, I could not run the test suite since it's not working for me on Windows 7.
Kind regards,
Johannes