Fix makespan experiments #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 67.38% 67.42% +0.04%
==========================================
Files 69 69
Lines 7729 7764 +35
==========================================
+ Hits 5208 5235 +27
- Misses 2521 2529 +8
|
csegarragonz
added a commit
that referenced
this pull request
Jul 25, 2023
This reverts commit fcf4891.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I bump faabric to work-around a long-running bug in the makespan experiment, that meant that it would not run since migrating from ZeroMQ to NNG.
In addition, I wrap all WAMR MPI calls in a try/catch statement to correctly propagate the exception through WAMR.