Clarify split for cross-compiled applications #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Nov 11, 2022
| { | ||
| faabric::util::initLogging(); | ||
|
|
||
| // Define command line arguments |
Collaborator
Author
There was a problem hiding this comment.
Moved this to runner_utils.cpp to be used both by func_runner and local_pool_runner.
csegarragonz
commented
Nov 11, 2022
| REQUIRE(!moduleRefA1.exports.empty()); | ||
| REQUIRE(!moduleRefB1.exports.empty()); | ||
| REQUIRE(moduleRefA1.memories.defs[0].type.size.max == MAX_WASM_MEMORY_PAGES); | ||
| REQUIRE(moduleRefA1.memories.defs[0].type.size.max == |
csegarragonz
commented
Nov 11, 2022
| # Wrapper script for running invoke in virtual env | ||
|
|
||
| source bin/workon.sh && inv -r faasmcli/faasmcli $@ | ||
| source bin/workon.sh && inv -r faasmcli/faasmcli "$@" |
Collaborator
Author
There was a problem hiding this comment.
Added quotes, as otherwise if we pass a command with quotes they would not be preserved.
pool_runner from the CLI
Merged
Shillaker
approved these changes
Nov 25, 2022
41845f4 to
892646f
Compare
892646f to
0f6e796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an offline discussion, we agreed on the split for cross-compiled example applications: libraries belonging to the sysroot live in
faasm/cppand everything else will live infasm/examples. The goal is to keep the cross-compiled applications together, but let them die if necessary. As a consequence, things likeFFmpegorImageMagickshould not be tested here.In this PR, I remove the
ffmpegtests and add a couple of features that we need for the newfaasm/examplesrepo:./bin/inv_wrapper.sh.As a consequence of the first point, we can now run:
See the main PR in faasm/examples#1