Scaffolding #1
Merged
Scaffolding #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88b450f to
8ca15d3
Compare
c13ea98 to
0b134f5
Compare
0b134f5 to
d97d64c
Compare
This was referenced Nov 11, 2022
Shillaker
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, we will keep the bigger applications that are likely to rot away here in a more-or-less organised fashion, whereas in
faasm/cppwe'll keep the core libraries that you would already expect in a commodity sysroot (e.g.zlib).As to this repo's structure, we include tasks to cross-compile all applications in a containerised environment and another container to run them. Both the building and the running step are tested in GHA. If something stops working, its just a matter of commenting out the test in GHA.
As to versioning, the building image is versioned with
${CPP_VERSION}_${PYTHON_VERSION}(as that should be the only thing that influences cross-compiled code), whereas the running image is tagged with the same tag as faasm. The tags can rot away, but it is a way to know with which toolchain or runtime the examples ship with.Together with this PR, I clean up from
faasm/faasmandfaasm/cppthe code that does not belong in there anymore:The best way to review this PR is to directly browse the branch.