-
Notifications
You must be signed in to change notification settings - Fork 70
Version 0.8.0 #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.8.0 #580
Conversation
|
|
||
| # Default names | ||
| ns = Collection( | ||
| bare_metal, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shillaker I guess we are missing the code for this task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? The file is here. All the bare metal stuff is legacy and needs to be removed fully in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my point was that I did not understand why this file was modified (i.e. the bare_metal namespace added).
| Jinja2==2.11.3 | ||
| matplotlib==3.3.4 | ||
| networkx==2.5.1 | ||
| numpy==1.21.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shillaker is there a reason to unpin the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the installation seems to fail on 20.04 saying it can't find version 1.19, but on 18.04 it says it can't find version 1.21. I'll replace it now though as this was just to debug issues temporarily.
39d60b7 to
4e2d2ab
Compare
|
|
||
| defaults: | ||
| run: | ||
| working-directory: /usr/local/code/faasm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't want to set this default working directory for jobs that do not run inside a container (like dist-tests) as /usr/local/code/faasm is not a valid path.
PS: I see you have already changed it.
faasm/conan-cache-action