Skip to content

Conversation

@Shillaker
Copy link
Collaborator

@Shillaker Shillaker commented Feb 11, 2022

  • Master build fixes
  • Fix task to build docs in GHA
  • Disabled broken OpenMP tests (will fix in a later PR)
  • Latest Faabric
  • Fix Python environment in GHA
  • Revert custom shell string introduced in Fixes to image build process #553 and use the more verbose approach (can simplify in a separate PR), as otherwise the tests just don't run at all.
  • Use faasm/conan-cache-action

@Shillaker Shillaker self-assigned this Feb 11, 2022
@Shillaker Shillaker marked this pull request as ready for review February 11, 2022 15:42

# Default names
ns = Collection(
bare_metal,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shillaker I guess we are missing the code for this task?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? The file is here. All the bare metal stuff is legacy and needs to be removed fully in a separate PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my point was that I did not understand why this file was modified (i.e. the bare_metal namespace added).

Jinja2==2.11.3
matplotlib==3.3.4
networkx==2.5.1
numpy==1.21.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shillaker is there a reason to unpin the version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the installation seems to fail on 20.04 saying it can't find version 1.19, but on 18.04 it says it can't find version 1.21. I'll replace it now though as this was just to debug issues temporarily.

@csegarragonz csegarragonz force-pushed the v080 branch 3 times, most recently from 39d60b7 to 4e2d2ab Compare February 11, 2022 18:35

defaults:
run:
working-directory: /usr/local/code/faasm
Copy link
Collaborator

@csegarragonz csegarragonz Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to set this default working directory for jobs that do not run inside a container (like dist-tests) as /usr/local/code/faasm is not a valid path.

PS: I see you have already changed it.

@Shillaker Shillaker merged commit bcdbf54 into master Feb 14, 2022
@Shillaker Shillaker deleted the v080 branch February 14, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants