Fixes to image build process #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed2336c to
a0fdb9b
Compare
5f0ae20 to
d85e941
Compare
d85e941 to
a6f9aac
Compare
a6f9aac to
fa29f56
Compare
57c1d3f to
bd0776d
Compare
bd0776d to
93c0695
Compare
bb93a69 to
d1f1e0c
Compare
d1f1e0c to
6cd09f2
Compare
Shillaker
reviewed
Dec 22, 2021
.github/workflows/tests.yml
Outdated
| - name: "Build codegen - Codegen Shared Obj" | ||
| run: inv -r faasmcli/faasmcli dev.cc codegen_shared_obj | ||
| run: | | ||
| source venv/bin/activate |
Collaborator
There was a problem hiding this comment.
Can we avoid this repetition with a custom shell or by using alias for inv at the start?
I think we can put bash as the default shell too.
Collaborator
Author
There was a problem hiding this comment.
I set a default shell (that activates the virtual env. before running the command) only for the job that runs the tests.
Note that we can't set the shell as a default for all the workflow as not all jobs run in the same container (thus don't have the venv set, neither they need it).
Shillaker
reviewed
Dec 22, 2021
5dd7ed1 to
b9c90ec
Compare
b9c90ec to
1d47bde
Compare
Shillaker
approved these changes
Dec 22, 2021
Collaborator
Shillaker
left a comment
There was a problem hiding this comment.
Awesome, nice job sorting this all out 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fix a series of issues I have run into whilst trying to release a new docker image:
site.ENABLE_USER_SITEin the package'ssetup.py(i.e. infaasmtoolsandfaasmcli) but this derived in other problems. In the end I have decided to use only virtual environments around (as we do in regular development environments). Note that, to prevent a clash between container and out-of-container builds in thevenvdirectory, I make out-of-container builds usevenv-bmas their virtual environment root.aws-sdk-cpp. This conan package seems very unstable and fragile, we revert to installing it as anExternalProjectin CMake. I add an interface library + alias to make the replacement transparent.Closes #324