-
Notifications
You must be signed in to change notification settings - Fork 70
Sanitized builds #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sanitized builds #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2ba035 to
928a622
Compare
Exclude faasm config just like faabric config from race tracking Don't do a full build in the conan-cache step Reformat dev.py Change commandline flag
928a622 to
1d5a97c
Compare
…s, use shared_ptr to prevent that from happening
csegarragonz
added a commit
that referenced
this pull request
Dec 7, 2021
…ks as detected by TSan
Shillaker
approved these changes
Dec 9, 2021
Collaborator
Shillaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nice trick with the build matrix.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off the faabric sanitized builds, add the same functionality to faasm. Reading through the docs I realized build matrix can be used to make the workflow description much more compact and integrate it into the main tests action.