stop roll() from failing if the new cache folder is not created#243
Conversation
Today I stumbled upon an error where it would fail when the cache folder was not present ```(typescript) Error: ENOENT: no such file or directory, rename 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache_' -> 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache'``` This PR fixes it by checking its existence before trying to rename it
|
@ezolenko There is any plan to release this fix on npm? Seems that on the repo we are already on 0.27.4, but this version was not published on npm. |
|
This should be in 0.27.3 on npm already (unless I messed up releases :)). |
Brings in ezolenko/rollup-plugin-typescript2#243 in order to fix jaredpalmer#888 and jaredpalmer#892.
|
@xaviergonz @ezolenko any chance one of you could explain how this fixes the root cause or what the root cause of this bug is? I investigated this a bit in jaredpalmer/tsdx#896 / jaredpalmer/tsdx#892 / jaredpalmer/tsdx#888 but did not really understand the root cause here. Per one of my comments there:
I'm not sure why one of the directories wouldn't exist during |
|
@xaviergonz @ezolenko following up as I still don't quite understand root cause here |
|
@agilgur5 I think the error was not due to uninitialized variable, but because directory itself went missing during the build. |
|
@ezolenko thanks, yea I figured that was the issue, but I still don't get why that would occur and if this were really an optimal solution to that. Based on the issues downstream it seems to happen when you build certain combinations of outputs with Rollup in parallel with the same cache directory for this plugin. I would think those actions would be additive to the cache as opposed to destructive and that the hashing means that a race condition shouldn't happen, but it doesn't seem to be the case. If it indeed a race condition like that, I would think there should be a better fix that prevents the directories from going missing / being deleted / being overwritten instead of just ignoring it, since just ignoring could make for consistent cache misses and therefore poor performance. I'm not entirely sure what causes that race though or why a race would be destructive. |
Today I stumbled upon an error where it would fail when the cache folder was not present
(typescript) Error: ENOENT: no such file or directory, rename 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache_' -> 'REDACTED\node_modules\.cache\rollup-plugin-typescript2/rpt2_759e2fd8d3f20c1a0805faf5404af6bea36632fd/code/cache'This PR fixes it by checking its existence before trying to rename it