Skip to content

fix: downgrade log level to silent#1321

Merged
Crunchyman-ralph merged 1 commit into
nextfrom
ralph/fix/cleanup.cli.errors
Oct 18, 2025
Merged

fix: downgrade log level to silent#1321
Crunchyman-ralph merged 1 commit into
nextfrom
ralph/fix/cleanup.cli.errors

Conversation

@Crunchyman-ralph

@Crunchyman-ralph Crunchyman-ralph commented Oct 18, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • 🐛 Bug fix
  • ✨ Feature
  • 🔌 Integration
  • 📝 Docs
  • 🧹 Refactor
  • Other:

Description

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

  • Created changeset: npm run changeset
  • Tests pass: npm test
  • Format check passes: npm run format-check (or npm run format to fix)
  • Addressed CodeRabbit comments (if any)
  • Linked related issues (if any)
  • Manually tested the changes

Changelog Entry

For Maintainers

  • PR title follows conventional commits
  • Target branch correct
  • Labels added
  • Milestone assigned (if applicable)

Summary by CodeRabbit

  • Chores
    • Logging output is now silent by default and requires explicit configuration to enable messages.

@changeset-bot

changeset-bot Bot commented Oct 18, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 02b2120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The default log level in Logger configuration is changed from WARN to SILENT. This ensures no log messages are output by default unless explicitly overridden through environment variables or configuration, with existing shouldLog logic remaining unchanged.

Changes

Cohort / File(s) Change Summary
Logger default configuration
packages/tm-core/src/logger/logger.ts		 Changed Logger.DEFAULT_CONFIG log level from WARN to SILENT to suppress logging by default

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: downgrade log level to silent" directly and clearly describes the main change in the changeset. The actual modification is changing the default log level from WARN to SILENT in Logger.DEFAULT_CONFIG, which is exactly what the title communicates. The title is concise, uses specific terminology (downgrade, log level, silent), and avoids vague or generic phrasing. A reviewer scanning the project history would immediately understand this pull request concerns a logging configuration adjustment.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ralph/fix/cleanup.cli.errors

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Oct 18, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 662e386 and 02b2120.

📒 Files selected for processing (1)
  • packages/tm-core/src/logger/logger.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/tm-core/src/logger/logger.ts (1)
packages/tm-core/src/logger/index.ts (1)
  • LogLevel (6-6)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test

Comment thread packages/tm-core/src/logger/logger.ts
@Crunchyman-ralph Crunchyman-ralph merged commit 555da2b into next Oct 18, 2025
8 checks passed
github-actions Bot added a commit that referenced this pull request Oct 18, 2025
@github-actions
docs: auto-update documentation based on changes in next branch
464c4ee 
  This PR was automatically generated to update documentation based on recent changes.

  Original commit: fix: downgrade log level to silent (#1321)\n\n\n

  Co-authored-by: Claude <claude-assistant@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Crunchyman-ralph