chore: improve release check for release-check and release flow by Crunchyman-ralph · Pull Request #1095 · eyaltoledano/claude-task-master

Crunchyman-ralph · 2025-08-06T21:04:23Z

What type of PR is this?

Description

Related Issues

How to Test This

# Example commands or steps

Expected result:

Contributor Checklist

Created changeset: npm run changeset
Tests pass: npm test
Format check passes: npm run format-check (or npm run format to fix)
Addressed CodeRabbit comments (if any)
Linked related issues (if any)
Manually tested the changes

Changelog Entry

For Maintainers

PR title follows conventional commits
Target branch correct
Labels added
Milestone assigned (if applicable)

Summary by CodeRabbit

Chores
- Improved pre-release mode checks in workflows by centralizing logic into a new Node.js script, resulting in clearer error messages and more consistent handling during pull requests and releases. No changes to user-facing features.

chore: exit pre-release mode

changeset-bot · 2025-08-06T21:04:26Z

⚠️ No Changeset found

Latest commit: a1b77b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-08-06T21:04:29Z

Walkthrough

A new Node.js script was added to check for an active pre-release mode by inspecting .changeset/pre.json. GitHub Actions workflows were updated to replace inline shell checks with invocations of this script, centralizing the pre-release mode logic and messaging in one place.

Changes

Cohort / File(s)	Change Summary
Pre-release mode check script `.github/scripts/check-pre-release-mode.mjs`	Introduced a Node.js script to detect active pre-release mode, print context-aware instructions, and exit with appropriate status.
GitHub Actions workflows `.github/workflows/release-check.yml`, `.github/workflows/release.yml`	Replaced inline shell scripts for pre-release mode checks with calls to the new Node.js script, simplifying workflow steps.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions Workflow
    participant check-pre-release-mode.mjs
    participant Filesystem

    GitHub Actions Workflow->>check-pre-release-mode.mjs: Invoke with context ("pull_request" or "main")
    check-pre-release-mode.mjs->>Filesystem: Locate project root/package.json
    check-pre-release-mode.mjs->>Filesystem: Check for .changeset/pre.json
    alt pre.json does not exist
        check-pre-release-mode.mjs-->>GitHub Actions Workflow: Exit 0 (no pre-release mode)
    else pre.json exists
        check-pre-release-mode.mjs->>Filesystem: Read and parse pre.json
        alt mode == "pre"
            check-pre-release-mode.mjs-->>GitHub Actions Workflow: Print error, exit 1
        else
            check-pre-release-mode.mjs-->>GitHub Actions Workflow: Exit 0
        end
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

chore: exit pre-release mode #1084: Modifies .changeset/pre.json to change the mode, directly affecting how the new script will behave.
chore: exit pre #1071: Changes the "mode" value in .changeset/pre.json, which is now checked by the new script.
chore: fix tag-extension package.json not found for extension #1073: Adds logic to find the project root by traversing directories, similar to the new script's approach.

Suggested reviewers

eyaltoledano

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/fix.ci.release

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4357af3 and a1b77b2.

📒 Files selected for processing (3)

.github/scripts/check-pre-release-mode.mjs (1 hunks)
.github/workflows/release-check.yml (1 hunks)
.github/workflows/release.yml (1 hunks)

🧰 Additional context used

🧠 Learnings (22)

📓 Common learnings

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/git_workflow.mdc:0-0
Timestamp: 2025-07-18T17:10:31.810Z
Learning: Pull Request descriptions must use the provided template, including Task Overview, Subtasks Completed, Implementation Details, Testing, Breaking Changes, and Related Tasks

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/git_workflow.mdc:0-0
Timestamp: 2025-07-18T17:10:31.810Z
Learning: Pull Request titles must follow the format: Task <ID>: <Task Title>

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/changeset.mdc:0-0
Timestamp: 2025-07-18T17:07:53.100Z
Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.

Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#1069
File: .changeset/fix-tag-complexity-detection.md:0-0
Timestamp: 2025-08-02T15:33:22.656Z
Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: eyaltoledano
PR: eyaltoledano/claude-task-master#1069
File: .changeset/floppy-news-buy.md:7-38
Timestamp: 2025-08-02T14:54:52.216Z
Learning: For major feature additions like new CLI commands, eyaltoledano prefers detailed changesets with comprehensive descriptions, usage examples, and feature explanations rather than minimal single-line summaries.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-31T22:07:14.034Z
Learning: Import Task Master's development workflow commands and guidelines, treat as if import is in the main CLAUDE.md file.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-31T22:07:49.716Z
Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-31T22:07:49.716Z
Learning: Applies to scripts/modules/commands.js : Integrate version checking in the CLI run function, starting the update check in the background and displaying notifications after command execution.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/new_features.mdc:0-0
Timestamp: 2025-07-18T17:12:57.903Z
Learning: Applies to scripts/modules/*.js : Ensure new features trigger migration when needed, handle migration errors gracefully, test feature behavior with pre-migration projects, and do not assume projects are already migrated.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/glossary.mdc:0-0
Timestamp: 2025-07-18T17:10:53.657Z
Learning: Guidelines for using Changesets (npm run changeset) to manage versioning and changelogs (changeset.mdc).

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/new_features.mdc:0-0
Timestamp: 2025-07-18T17:12:57.903Z
Learning: Applies to scripts/modules/*.js : Ensure new features work with existing projects seamlessly, supporting both legacy and tagged task data formats, and support silent migration during feature usage.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: assets/.windsurfrules:0-0
Timestamp: 2025-07-18T17:19:27.365Z
Learning: When implementation differs significantly from planned approach, call `node scripts/dev.js update --from=<futureTaskId> --prompt="<explanation>"` to update tasks.json.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/test_workflow.mdc:0-0
Timestamp: 2025-08-03T12:13:33.875Z
Learning: Applies to package.json : Add and update test scripts in package.json to include test, test:watch, test:coverage, test:unit, test:integration, test:e2e, and test:ci

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-31T22:07:49.716Z
Learning: Applies to scripts/modules/commands.js : Implement semantic version comparison and display attractive update notifications using boxen.

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Implement semantic version comparison and display attractive update notifications using boxen.

📚 Learning: applies to .changeset/*.md : when running `npm run changeset` or `npx changeset add`, provide a conc...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/changeset.mdc:0-0
Timestamp: 2025-07-18T17:07:53.100Z
Learning: Applies to .changeset/*.md : When running `npm run changeset` or `npx changeset add`, provide a concise summary of the changes for the `CHANGELOG.md` in imperative mood, typically a single line, and not a detailed Git commit message.

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: guidelines for using changesets (npm run changeset) to manage versioning and changelogs (changeset.m...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/glossary.mdc:0-0
Timestamp: 2025-07-18T17:10:53.657Z
Learning: Guidelines for using Changesets (npm run changeset) to manage versioning and changelogs (changeset.mdc).

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/commands.js : implement version checking to notify users of available upd...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/*.js : ensure new features work with existing projects seamlessly, suppor...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/new_features.mdc:0-0
Timestamp: 2025-07-18T17:12:57.903Z
Learning: Applies to scripts/modules/*.js : Ensure new features work with existing projects seamlessly, supporting both legacy and tagged task data formats, and support silent migration during feature usage.

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/*.js : ensure new features trigger migration when needed, handle migratio...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/new_features.mdc:0-0
Timestamp: 2025-07-18T17:12:57.903Z
Learning: Applies to scripts/modules/*.js : Ensure new features trigger migration when needed, handle migration errors gracefully, test feature behavior with pre-migration projects, and do not assume projects are already migrated.

Applied to files:

.github/workflows/release-check.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/task-manager.js : use consistent formatting for task files, include all t...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/tasks.mdc:0-0
Timestamp: 2025-07-18T17:14:29.399Z
Learning: Applies to scripts/modules/task-manager.js : Use consistent formatting for task files, include all task properties in text files, and format dependencies with status indicators.

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml

📚 Learning: applies to scripts/modules/commands.js : integrate version checking in the cli run function, startin...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-31T22:07:49.716Z
Learning: Applies to scripts/modules/commands.js : Integrate version checking in the CLI run function, starting the update check in the background and displaying notifications after command execution.

Applied to files:

.github/workflows/release-check.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/dependency-manager.js : track and report changes made during dependency c...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:40.548Z
Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Applied to files:

.github/workflows/release-check.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: run npm run test:coverage before commits to ensure all tests pass with sufficient coverage...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/test_workflow.mdc:0-0
Timestamp: 2025-08-03T12:13:33.875Z
Learning: Run npm run test:coverage before commits to ensure all tests pass with sufficient coverage

Applied to files:

.github/workflows/release-check.yml
.github/workflows/release.yml

📚 Learning: when implementation differs significantly from planned approach, call `node scripts/dev.js update --...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: assets/.windsurfrules:0-0
Timestamp: 2025-07-18T17:19:27.365Z
Learning: When implementation differs significantly from planned approach, call `node scripts/dev.js update --from=<futureTaskId> --prompt="<explanation>"` to update tasks.json.

Applied to files:

.github/workflows/release.yml

📚 Learning: applies to scripts/modules/task-manager/**/*.js : do not call ai-specific getters (like `getmainmode...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/utilities.mdc:0-0
Timestamp: 2025-07-18T17:18:17.759Z
Learning: Applies to scripts/modules/task-manager/**/*.js : Do not call AI-specific getters (like `getMainModelId`, `getMainMaxTokens`) from core logic functions in `scripts/modules/task-manager/*`; instead, pass the `role` to the unified AI service.

Applied to files:

.github/workflows/release.yml

📚 Learning: applies to scripts/modules/dependency-manager.js : remove references to non-existent tasks during va...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/dependencies.mdc:0-0
Timestamp: 2025-07-18T17:09:45.690Z
Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Applied to files:

.github/workflows/release.yml

📚 Learning: applies to scripts/modules/task-manager.js : extract tasks from prd documents using ai, create them ...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/tasks.mdc:0-0
Timestamp: 2025-07-18T17:14:29.399Z
Learning: Applies to scripts/modules/task-manager.js : Extract tasks from PRD documents using AI, create them in the current tag context (defaulting to 'master'), provide clear prompts to guide AI task generation, and validate/clean up AI-generated tasks.

Applied to files:

.github/workflows/release.yml
.github/scripts/check-pre-release-mode.mjs

📚 Learning: every pull request containing new features, bug fixes, breaking changes, performance improvements, s...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/changeset.mdc:0-0
Timestamp: 2025-07-18T17:07:53.100Z
Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/commands.js : validate file existence for critical file operations, provi...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/* : all commands must find projectroot with error handling before proceed...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/tags.mdc:0-0
Timestamp: 2025-07-18T17:13:30.188Z
Learning: Applies to scripts/modules/* : All commands must find projectRoot with error handling before proceeding

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/utils/contextgatherer.js : gracefully handle missing files with warnings,...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/context_gathering.mdc:0-0
Timestamp: 2025-07-18T17:09:13.815Z
Learning: Applies to scripts/modules/utils/contextGatherer.js : Gracefully handle missing files with warnings, validate task IDs, continue processing even if some context sources fail, and provide fallback behavior when context gathering fails.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/* : all commands must pass { projectroot, tag } as context to core functi...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/tags.mdc:0-0
Timestamp: 2025-07-18T17:13:30.188Z
Learning: Applies to scripts/modules/* : All commands must pass { projectRoot, tag } as context to core functions

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/commands.js : use path.join() to construct file paths, follow established...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-18T17:08:48.695Z
Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths, follow established naming conventions (like task_001.txt), check file existence before deletion, and handle file deletion errors gracefully.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: applies to scripts/modules/commands.js : for ai-powered commands that benefit from project context, ...

Learnt from: CR
PR: eyaltoledano/claude-task-master#0
File: .cursor/rules/commands.mdc:0-0
Timestamp: 2025-07-31T22:07:49.716Z
Learning: Applies to scripts/modules/commands.js : For AI-powered commands that benefit from project context, use the ContextGatherer utility for multi-source context extraction, support task IDs, file paths, custom context, and project tree, implement fuzzy search for automatic task discovery, and display detailed token breakdown for transparency.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

📚 Learning: in the claude task master system, core task-manager functions are designed with fallback mechanisms ...

Learnt from: Crunchyman-ralph
PR: eyaltoledano/claude-task-master#943
File: scripts/modules/task-manager/move-task.js:24-24
Timestamp: 2025-07-18T05:38:17.352Z
Learning: In the Claude Task Master system, core task-manager functions are designed with fallback mechanisms for missing projectRoot parameters using the pattern `const projectRoot = providedProjectRoot || findProjectRoot();`. The readJSON and writeJSON functions have default parameters (projectRoot = null, tag = null) and handle missing parameters gracefully. Adding strict validation to these core functions would break the established flexible architecture pattern.

Applied to files:

.github/scripts/check-pre-release-mode.mjs

🔇 Additional comments (5)

.github/scripts/check-pre-release-mode.mjs (2)

1-11: LGTM! Well-structured imports and setup.

The imports are appropriate for the functionality needed, and the context detection from command line arguments or environment variables is well-implemented.

42-99: LGTM! Comprehensive error handling and context-specific messaging.

The error handling for JSON parsing and the context-specific error messages provide clear guidance for different scenarios (PR vs main branch). The exit codes are appropriate for CI/CD integration.

.github/workflows/release.yml (1)

42-42: LGTM! Proper script invocation with correct context.

The replacement of inline shell script with the centralized Node.js script is a good refactoring. The context argument "main" is appropriate for this workflow that runs on pushes to the main branch.

.github/workflows/release-check.yml (2)

21-21: LGTM! Correct context argument for pull request workflow.

The script invocation uses the appropriate context argument "pull_request" which matches this workflow's trigger on pull requests to main.

1-22: Changeset files already present – no missing changeset needed

The PR includes the following .changeset files, so the request to add one is not applicable:

.changeset/fuzzy-words-count.md

.changeset/tender-trams-refuse.md

.changeset/vast-sites-leave.md

Please confirm that one of these covers the bug fix and disregard the missing-changeset request.

Likely an incorrect or invalid review comment.

coderabbitai · 2025-08-06T21:12:58Z

+
+function findRootDir(startDir) {
+	let currentDir = resolve(startDir);
+	while (currentDir !== '/') {


⚠️ Potential issue

Fix cross-platform compatibility issue.

The hard-coded root path '/' will only work on Unix-like systems and will fail on Windows where the root could be 'C:\\' or similar.

- while (currentDir !== '/') { + while (currentDir !== resolve(currentDir, '..')) {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

while (currentDir !== '/') {

- while (currentDir !== '/') {

+ while (currentDir !== resolve(currentDir, '..')) {

🤖 Prompt for AI Agents

In .github/scripts/check-pre-release-mode.mjs at line 14, replace the hard-coded root path '/' with a cross-platform method to detect the root directory. Use Node.js path or filesystem utilities to determine when the current directory is the root, ensuring compatibility on both Unix-like and Windows systems.

this node script is only destined to run in the CI which is unix

@Crunchyman-ralph, thank you for the clarification! You're absolutely right - since this script is specifically designed to run in Unix-based CI environments, the hard-coded '/' root path is perfectly appropriate. My suggestion for cross-platform compatibility was unnecessary given this specific use case.

✏️ Learnings added

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1095 File: .github/scripts/check-pre-release-mode.mjs:14-14 Timestamp: 2025-08-06T21:17:00.405Z Learning: CI scripts in `.github/scripts/` are designed to run only in Unix-based CI environments and do not require Windows compatibility, so hard-coded Unix paths like '/' are acceptable.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

🧠 Learnings used

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must find projectRoot with error handling before proceeding

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must pass { projectRoot, tag } as context to core functions

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths, follow established naming conventions (like task_001.txt), check file existence before deletion, and handle file deletion errors gracefully.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/utilities.mdc:0-0 Timestamp: 2025-07-18T17:18:17.759Z Learning: Applies to scripts/modules/utils.js : Use `path.join()` for cross-platform path construction, `path.resolve()` for absolute paths, and validate paths before file operations.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/context_gathering.mdc:0-0 Timestamp: 2025-07-18T17:09:13.815Z Learning: Applies to scripts/modules/utils/contextGatherer.js : Gracefully handle missing files with warnings, validate task IDs, continue processing even if some context sources fail, and provide fallback behavior when context gathering fails.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/context_gathering.mdc:0-0 Timestamp: 2025-07-18T17:09:13.815Z Learning: Applies to scripts/modules/utils/contextGatherer.js : Set reasonable file size limits (50KB default) and limit project tree depth (3-5 levels) when gathering context for AI-powered commands.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/utilities.mdc:0-0 Timestamp: 2025-07-18T17:18:17.759Z Learning: Applies to mcp-server/src/core/utils/path-utils.js : Call `findTasksJsonPath(args, log)` from within direct function wrappers in `mcp-server/src/core/direct-functions/` to get the absolute path to the relevant `tasks.json`.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/mcp.mdc:0-0 Timestamp: 2025-07-18T17:11:36.732Z Learning: Applies to mcp-server/src/core/direct-functions/*.js : The *Direct function is responsible for finding the exact tasks.json path using findTasksJsonPath, relying on the projectRoot passed in args.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tests.mdc:0-0 Timestamp: 2025-07-18T17:16:13.793Z Learning: Applies to **/*.test.js : Verify file operations use the correct paths in expect statements.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/mcp.mdc:0-0 Timestamp: 2025-07-18T17:11:36.732Z Learning: Applies to mcp-server/src/core/direct-functions/*.js : Use path.join() instead of string concatenation for file paths, and follow established file naming conventions (e.g., 'task_001.txt') in direct functions.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths; do not use string concatenation for paths.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/utilities.mdc:0-0 Timestamp: 2025-07-18T17:18:17.759Z Learning: Applies to mcp-server/src/tools/utils.js : Use `normalizeProjectRoot(rawPath, log)`, `getRawProjectRootFromSession(session, log)`, and `withNormalizedProjectRoot(executeFn)` in `mcp-server/src/tools/utils.js` to ensure project root paths are normalized for MCP tools.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Do not construct file paths with string concatenation.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tests.mdc:0-0 Timestamp: 2025-07-18T17:16:13.793Z Learning: Applies to **/*.test.js : Use test-specific file paths (e.g., 'test-tasks.json') for all file operations in tests.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/mcp.mdc:0-0 Timestamp: 2025-07-18T17:11:36.732Z Learning: Applies to mcp-server/src/tools/*.js : All MCP tool execute methods that require access to the project root MUST be wrapped with the withNormalizedProjectRoot Higher-Order Function (HOF) from mcp-server/src/tools/utils.js.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/**/*.test.js : Test CLI and MCP interfaces with real task data, verify end-to-end workflows across tag contexts, and test error scenarios and recovery in integration tests.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: assets/.windsurfrules:0-0 Timestamp: 2025-07-18T17:19:27.365Z Learning: Use the global `task-master` CLI command instead of directly invoking `node scripts/dev.js` for all task management operations.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/test_workflow.mdc:0-0 Timestamp: 2025-08-03T12:13:33.875Z Learning: Run npm run test:coverage before commits to ensure all tests pass with sufficient coverage

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/test_workflow.mdc:0-0 Timestamp: 2025-08-03T12:13:33.875Z Learning: Applies to package.json : Add and update test scripts in package.json to include test, test:watch, test:coverage, test:unit, test:integration, test:e2e, and test:ci

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/utilities.mdc:0-0 Timestamp: 2025-07-18T17:18:17.759Z Learning: Applies to scripts/modules/utils.js : Place utilities used primarily by the core `task-master` CLI logic and command modules (`scripts/modules/*`) into `scripts/modules/utils.js`.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: assets/.windsurfrules:0-0 Timestamp: 2025-07-18T17:19:27.365Z Learning: When implementation differs significantly from planned approach, call `node scripts/dev.js update --from=<futureTaskId> --prompt="<explanation>"` to update tasks.json.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : Every command that reads or writes tasks.json must be tag-aware

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/**/*.test.js : Test core logic independently with both data formats, mock file system operations, test tag resolution behavior, and verify migration compatibility in unit tests.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Applies to .changeset/*.md : When running `npm run changeset` or `npx changeset add`, provide a concise summary of the changes for the `CHANGELOG.md` in imperative mood, typically a single line, and not a detailed Git commit message.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/glossary.mdc:0-0 Timestamp: 2025-07-18T17:10:53.657Z Learning: Guidelines for using Changesets (npm run changeset) to manage versioning and changelogs (changeset.mdc).

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features trigger migration when needed, handle migration errors gracefully, test feature behavior with pre-migration projects, and do not assume projects are already migrated.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features work with existing projects seamlessly, supporting both legacy and tagged task data formats, and support silent migration during feature usage.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:45.690Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:40.548Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1069 File: .changeset/fix-tag-complexity-detection.md:0-0 Timestamp: 2025-08-02T15:33:22.656Z Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request descriptions must use the provided template, including Task Overview, Subtasks Completed, Implementation Details, Testing, Breaking Changes, and Related Tasks

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request titles must follow the format: Task <ID>: <Task Title>

Learnt from: eyaltoledano PR: eyaltoledano/claude-task-master#1069 File: .changeset/floppy-news-buy.md:7-38 Timestamp: 2025-08-02T14:54:52.216Z Learning: For major feature additions like new CLI commands, eyaltoledano prefers detailed changesets with comprehensive descriptions, usage examples, and feature explanations rather than minimal single-line summaries.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: CLAUDE.md:0-0 Timestamp: 2025-07-31T22:07:14.034Z Learning: Import Task Master's development workflow commands and guidelines, treat as if import is in the main CLAUDE.md file.

coderabbitai · 2025-08-06T21:12:58Z

+				const pkg = JSON.parse(
+					readFileSync(join(currentDir, 'package.json'), 'utf8')
+				);
+				if (pkg.name === 'task-master-ai' || pkg.repository) {


🛠️ Refactor suggestion

Improve package.json validation logic.

The condition pkg.repository will match any truthy value, which could lead to false positives. Consider being more specific about what constitutes a valid repository field.

- if (pkg.name === 'task-master-ai' || pkg.repository) { + if ( + pkg.name === 'task-master-ai' || + (pkg.repository && (typeof pkg.repository === 'string' || pkg.repository.url)) + ) {

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

if (pkg.name === 'task-master-ai' || pkg.repository) {

if (

pkg.name === 'task-master-ai' ||

(pkg.repository && (typeof pkg.repository === 'string' || pkg.repository.url))

) {

🤖 Prompt for AI Agents

In .github/scripts/check-pre-release-mode.mjs at line 20, the condition checking pkg.repository is too broad and may cause false positives. Refine this condition to specifically verify that pkg.repository is an object with a valid URL or string property, ensuring it accurately represents a valid repository field in package.json.

I think I'll just ignore this for now

@Crunchyman-ralph, understood! I'll skip this suggestion for now. Feel free to revisit it later if needed.

🧠 Learnings used

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must find projectRoot with error handling before proceeding

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must pass { projectRoot, tag } as context to core functions

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths, follow established naming conventions (like task_001.txt), check file existence before deletion, and handle file deletion errors gracefully.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tasks.mdc:0-0 Timestamp: 2025-07-18T17:14:29.399Z Learning: Applies to scripts/modules/task-manager.js : Extract tasks from PRD documents using AI, create them in the current tag context (defaulting to 'master'), provide clear prompts to guide AI task generation, and validate/clean up AI-generated tasks.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : For AI-powered commands that benefit from project context, use the ContextGatherer utility for multi-source context extraction, support task IDs, file paths, custom context, and project tree, implement fuzzy search for automatic task discovery, and display detailed token breakdown for transparency.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : For AI-powered commands that benefit from project context, use the ContextGatherer utility for multi-source context extraction, support task IDs, file paths, custom context, and project tree, implement fuzzy search for automatic task discovery, and display detailed token breakdown for transparency.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/utilities.mdc:0-0 Timestamp: 2025-07-18T17:18:17.759Z Learning: Applies to mcp-server/src/core/utils/path-utils.js : Call `findTasksJsonPath(args, log)` from within direct function wrappers in `mcp-server/src/core/direct-functions/` to get the absolute path to the relevant `tasks.json`.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/context_gathering.mdc:0-0 Timestamp: 2025-07-18T17:09:13.815Z Learning: Applies to scripts/modules/utils/contextGatherer.js : Gracefully handle missing files with warnings, validate task IDs, continue processing even if some context sources fail, and provide fallback behavior when context gathering fails.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:45.690Z Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:40.548Z Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#943 File: scripts/modules/task-manager/move-task.js:24-24 Timestamp: 2025-07-18T05:38:17.352Z Learning: In the Claude Task Master system, core task-manager functions are designed with fallback mechanisms for missing projectRoot parameters using the pattern `const projectRoot = providedProjectRoot || findProjectRoot();`. The readJSON and writeJSON functions have default parameters (projectRoot = null, tag = null) and handle missing parameters gracefully. Adding strict validation to these core functions would break the established flexible architecture pattern.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Use consistent file naming conventions: 'task_${id.toString().padStart(3, '0')}.txt', use path.join for composing file paths, and use appropriate file extensions (.txt for tasks, .json for data).

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tests.mdc:0-0 Timestamp: 2025-07-18T17:16:13.793Z Learning: Applies to **/*.test.js : Verify modifications on the in-memory task objects passed to writeJSON.

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#997 File: apps/extension/package.publish.json:2-8 Timestamp: 2025-07-31T20:49:04.638Z Learning: In the eyaltoledano/claude-task-master repository, the VS Code extension uses a 3-file packaging system where package.json (with name "extension") is for development within the monorepo, while package.publish.json (with name "task-master-hamster") contains the clean manifest for VS Code marketplace publishing. The different names are intentional and serve distinct purposes in the build and publishing workflow.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tasks.mdc:0-0 Timestamp: 2025-07-18T17:14:29.399Z Learning: Applies to scripts/modules/task-manager.js : Use consistent formatting for task files, include all task properties in text files, and format dependencies with status indicators.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: assets/.windsurfrules:0-0 Timestamp: 2025-07-18T17:19:27.365Z Learning: Use `task-master validate-dependencies` to check for and identify invalid dependencies in tasks.json and task files.

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1069 File: .changeset/fix-tag-complexity-detection.md:0-0 Timestamp: 2025-08-02T15:33:22.656Z Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/ai_services.mdc:0-0 Timestamp: 2025-07-18T17:06:57.833Z Learning: Applies to scripts/modules/task-manager/*.js : Use `generateTextService` and implement robust manual JSON parsing (with Zod validation after parsing) when structured output is needed, as `generateObjectService` has shown unreliability with some providers/schemas.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Applies to .changeset/*.md : When running `npm run changeset` or `npx changeset add`, provide a concise summary of the changes for the `CHANGELOG.md` in imperative mood, typically a single line, and not a detailed Git commit message.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/glossary.mdc:0-0 Timestamp: 2025-07-18T17:10:53.657Z Learning: Guidelines for using Changesets (npm run changeset) to manage versioning and changelogs (changeset.mdc).

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features trigger migration when needed, handle migration errors gracefully, test feature behavior with pre-migration projects, and do not assume projects are already migrated.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features work with existing projects seamlessly, supporting both legacy and tagged task data formats, and support silent migration during feature usage.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: assets/.windsurfrules:0-0 Timestamp: 2025-07-18T17:19:27.365Z Learning: When implementation differs significantly from planned approach, call `node scripts/dev.js update --from=<futureTaskId> --prompt="<explanation>"` to update tasks.json.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:45.690Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:40.548Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request descriptions must use the provided template, including Task Overview, Subtasks Completed, Implementation Details, Testing, Breaking Changes, and Related Tasks

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request titles must follow the format: Task <ID>: <Task Title>

Learnt from: eyaltoledano PR: eyaltoledano/claude-task-master#1069 File: .changeset/floppy-news-buy.md:7-38 Timestamp: 2025-08-02T14:54:52.216Z Learning: For major feature additions like new CLI commands, eyaltoledano prefers detailed changesets with comprehensive descriptions, usage examples, and feature explanations rather than minimal single-line summaries.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: CLAUDE.md:0-0 Timestamp: 2025-07-31T22:07:14.034Z Learning: Import Task Master's development workflow commands and guidelines, treat as if import is in the main CLAUDE.md file.

coderabbitai · 2025-08-06T21:12:58Z

+	const rootDir = findRootDir(__dirname);
+	const preJsonPath = join(rootDir, '.changeset', 'pre.json');


🧹 Nitpick (assertive)

Add validation for changeset directory structure.

The script assumes the .changeset directory exists when constructing the path to pre.json. Consider validating the directory structure for better error reporting.

const rootDir = findRootDir(__dirname); + const changesetDir = join(rootDir, '.changeset'); + if (!existsSync(changesetDir)) { + console.log('✅ No .changeset directory found - not in active pre-release mode'); + process.exit(0); + } - const preJsonPath = join(rootDir, '.changeset', 'pre.json'); + const preJsonPath = join(changesetDir, 'pre.json');

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents

In .github/scripts/check-pre-release-mode.mjs around lines 33 to 34, the code assumes the .changeset directory exists without validation. Add a check to verify that the .changeset directory exists at the expected location before constructing the path to pre.json. If the directory is missing, throw or log a clear error message to improve error reporting and prevent downstream failures.

there's no possibility in this project that there isn't a .changeset directory...

@Crunchyman-ralph, understood! Thanks for clarifying that the .changeset directory is guaranteed to exist in this project's structure.

✏️ Learnings added

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1095 File: .github/scripts/check-pre-release-mode.mjs:33-34 Timestamp: 2025-08-06T21:16:02.249Z Learning: In the claude-task-master project, the .changeset directory is guaranteed to exist as part of the fundamental project structure, so validation checks for its existence are unnecessary.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

🧠 Learnings used

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Validate file existence for critical file operations, provide context-specific validation for identifiers, and check required API keys for features that depend on them.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must pass { projectRoot, tag } as context to core functions

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Integrate version checking in the CLI run function, starting the update check in the background and displaying notifications after command execution.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Use path.join() to construct file paths, follow established naming conventions (like task_001.txt), check file existence before deletion, and handle file deletion errors gracefully.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tags.mdc:0-0 Timestamp: 2025-07-18T17:13:30.188Z Learning: Applies to scripts/modules/* : All commands must find projectRoot with error handling before proceeding

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: assets/.windsurfrules:0-0 Timestamp: 2025-07-18T17:19:27.365Z Learning: When implementation differs significantly from planned approach, call `node scripts/dev.js update --from=<futureTaskId> --prompt="<explanation>"` to update tasks.json.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:45.690Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:40.548Z Learning: Applies to scripts/modules/dependency-manager.js : Track and report changes made during dependency cleanup

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-31T22:07:49.716Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/tests.mdc:0-0 Timestamp: 2025-07-18T17:16:13.793Z Learning: Applies to **/*.test.js : Verify file operations use the correct paths in expect statements.

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1069 File: .changeset/fix-tag-complexity-detection.md:0-0 Timestamp: 2025-08-02T15:33:22.656Z Learning: For changeset files (.changeset/*.md), Crunchyman-ralph prefers to ignore formatting nitpicks about blank lines between frontmatter and descriptions, as he doesn't mind having them and wants to avoid such comments in future reviews.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Applies to .cursor/rules/** : Do not add a changeset for changes only to files within `.cursor/rules/` that solely guide internal development practices for this specific repository.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/glossary.mdc:0-0 Timestamp: 2025-07-18T17:10:53.657Z Learning: Guidelines for using Changesets (npm run changeset) to manage versioning and changelogs (changeset.mdc).

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:45.690Z Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/dependencies.mdc:0-0 Timestamp: 2025-07-18T17:09:40.548Z Learning: Applies to scripts/modules/dependency-manager.js : Remove references to non-existent tasks during validation

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Applies to .changeset/*.md : When running `npm run changeset` or `npx changeset add`, provide a concise summary of the changes for the `CHANGELOG.md` in imperative mood, typically a single line, and not a detailed Git commit message.

Learnt from: Crunchyman-ralph PR: eyaltoledano/claude-task-master#1035 File: .changeset/quiet-rabbits-bathe.md:5-10 Timestamp: 2025-07-23T16:03:42.784Z Learning: For changeset files (.changeset/*.md), avoid suggesting punctuation for bullet points as the project intentionally omits punctuation to make the generated changelog feel more natural.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Do not add a changeset for local configuration changes, such as updates to personal editor settings or local `.env` files.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Always stage and commit the generated `.changeset/*.md` file along with your relevant code changes.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/changeset.mdc:0-0 Timestamp: 2025-07-18T17:07:53.100Z Learning: Every pull request containing new features, bug fixes, breaking changes, performance improvements, significant refactoring, user-facing documentation updates, dependency updates, or impactful build/tooling changes should include a changeset file.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to .changeset/* : Create appropriate changesets for new features, use semantic versioning, include tagged system information in release notes, and document breaking changes if any.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features trigger migration when needed, handle migration errors gracefully, test feature behavior with pre-migration projects, and do not assume projects are already migrated.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/commands.mdc:0-0 Timestamp: 2025-07-18T17:08:48.695Z Learning: Applies to scripts/modules/commands.js : Implement version checking to notify users of available updates, use non-blocking version checks, and display update notifications after command completion.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/new_features.mdc:0-0 Timestamp: 2025-07-18T17:12:57.903Z Learning: Applies to scripts/modules/*.js : Ensure new features work with existing projects seamlessly, supporting both legacy and tagged task data formats, and support silent migration during feature usage.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request descriptions must use the provided template, including Task Overview, Subtasks Completed, Implementation Details, Testing, Breaking Changes, and Related Tasks

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: .cursor/rules/git_workflow.mdc:0-0 Timestamp: 2025-07-18T17:10:31.810Z Learning: Pull Request titles must follow the format: Task <ID>: <Task Title>

Learnt from: eyaltoledano PR: eyaltoledano/claude-task-master#1069 File: .changeset/floppy-news-buy.md:7-38 Timestamp: 2025-08-02T14:54:52.216Z Learning: For major feature additions like new CLI commands, eyaltoledano prefers detailed changesets with comprehensive descriptions, usage examples, and feature explanations rather than minimal single-line summaries.

Learnt from: CR PR: eyaltoledano/claude-task-master#0 File: CLAUDE.md:0-0 Timestamp: 2025-07-31T22:07:14.034Z Learning: Import Task Master's development workflow commands and guidelines, treat as if import is in the main CLAUDE.md file.

…toledano#1095) * chore: improve release check for release-check and release flow * chore: fix format

Crunchyman-ralph added 2 commits August 4, 2025 20:43

Release 0.23.1 #1084 from eyaltoledano/next

37fb569

chore: exit pre-release mode

chore: improve release check for release-check and release flow

e3a7198

chore: fix format

a1b77b2

coderabbitai Bot reviewed Aug 6, 2025

View reviewed changes

Crunchyman-ralph merged commit fcf14e0 into next Aug 6, 2025
4 checks passed

Crunchyman-ralph deleted the chore/fix.ci.release branch August 6, 2025 21:19

coderabbitai Bot mentioned this pull request Aug 7, 2025

chore: fix CI checker, improve it #1099

Merged

16 tasks

Crunchyman-ralph added a commit to iamladi/claude-task-master that referenced this pull request Aug 11, 2025

chore: improve release check for release-check and release flow (eyal…

0238dbc

…toledano#1095) * chore: improve release check for release-check and release flow * chore: fix format

Crunchyman-ralph added a commit to iamladi/claude-task-master that referenced this pull request Aug 11, 2025

chore: improve release check for release-check and release flow (eyal…

af16c45

…toledano#1095) * chore: improve release check for release-check and release flow * chore: fix format

This was referenced Aug 11, 2025

feat: add --compact flag for minimal task list output #1054

Merged

feat: CLI & MCP progress tracking for parse-prd command #1048

Merged

This was referenced Sep 17, 2025

chore: fix pre-release CI #1213

Merged

chore: fix CI failure #1233

Merged

This was referenced Dec 4, 2025

Feat Add Snowflake Cortex provider #1485

Closed

Release 0.37.1 #1483

Merged

	while (currentDir !== '/') {
	- while (currentDir !== '/') {
	+ while (currentDir !== resolve(currentDir, '..')) {

		const rootDir = findRootDir(__dirname);
		const preJsonPath = join(rootDir, '.changeset', 'pre.json');

Conversation

Crunchyman-ralph commented Aug 6, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

Related Issues

How to Test This

Contributor Checklist

Changelog Entry

For Maintainers

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Crunchyman-ralph Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Crunchyman-ralph Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Crunchyman-ralph Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Crunchyman-ralph commented Aug 6, 2025 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Aug 6, 2025 •

edited

Loading

coderabbitai Bot commented Aug 6, 2025 •

edited

Loading

coderabbitai Bot Aug 6, 2025 •

edited

Loading

coderabbitai Bot Aug 6, 2025 •

edited

Loading

coderabbitai Bot Aug 6, 2025 •

edited

Loading