fix: deleting the whole secret when it is empty#5927
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Feb 13, 2026
Merged
fix: deleting the whole secret when it is empty#5927Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
WalkthroughThe PR enhances 1Password provider's DeleteSecret functionality by clearing empty section placeholders to enable proper deletion and treating non-existent key lookups as successful no-ops, allowing graceful handling of items with only placeholder sections and already-deleted items. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
moolen
approved these changes
Feb 13, 2026
|
nutmos
pushed a commit
to nutmos/external-secrets
that referenced
this pull request
Feb 18, 2026
Signed-off-by: Nattapong Ekudomsuk <nuttapong_mos@hotmail.com>
dsp0x4
pushed a commit
to dsp0x4/external-secrets
that referenced
this pull request
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
Basically, the SDK was not returning when the key was not found and the connect service looks like can have an empty item in it which is weird, but it is what it is.
Related Issue
Fixes #5753
Proposed Changes
How do you like to solve the issue and why?
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewableFix deletion of empty 1Password secrets
Addresses hanging deletion operations when using PushSecret with multiple keys against 1Password Connect Server. The fix implements three key changes:
Empty section handling: When a 1Password item contains only an empty placeholder section (with empty ID and Label), the section is now cleared to allow the item to be deleted.
Non-existent key handling: Treats deletion of non-existent keys as a no-op by returning success instead of an error, preventing deletion loops from failing.
Test coverage: Adds tests for deleting items with empty sections and for deleting multiple fields from the same item in sequence.
These changes ensure that 1Password items are properly removed when they become empty after field deletions, resolving indefinite hangs in the deletion process.