chore: remove unmaintained secret stores by Skarlso · Pull Request #5918 · external-secrets/external-secrets

Skarlso · 2026-02-02T18:04:52Z

Problem Statement

This will be release with version 2.0.0.

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

charts
release
testing
security
templating

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Summary

This PR removes two unmaintained secret store providers from the External Secrets Operator in preparation for v2.0.0:

Alibaba Cloud KMS and Device42 providers are completely removed, including:

API type definitions and CRD schemas
Provider implementation and client libraries
Authentication and secret retrieval logic
End-to-end tests and unit tests
Mock/fake implementations for testing
Documentation and examples
Provider registration code
Module dependencies and go.mod entries
CODEOWNERS entries
API documentation

Files affected: 40+ files deleted or modified, totaling approximately 2,300+ lines removed across:

Type definitions (secretstore_alibaba_types.go, secretstore_device42_types.go)
Provider implementations (providers/v1/alibaba/, providers/v1/device42/)
Tests and mocks
CRD definitions and snapshots
Documentation (docs/provider/alibaba.md, docs/provider/device42.md)
API reference and stability matrix

The changes are purely removal-based with no new functionality introduced. All references to these providers are cleanly de-registered from the framework.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

Skarlso · 2026-02-02T18:05:04Z

/ok-to-test sha=aa0867dab00a5cc2fa4ab1788be28323a02551eb

coderabbitai · 2026-02-02T18:05:11Z

Walkthrough

This pull request removes complete support for Alibaba Cloud KMS and Device42 secret providers from the External Secrets Operator, including API type definitions, provider implementations, CRD schemas, documentation, tests, and build configuration. All related files and references to these two providers are deleted.

Changes

Cohort / File(s)	Summary
API Types and Core Infrastructure `CODEOWNERS.md`, `apis/externalsecrets/v1/secretstore_alibaba_types.go`, `apis/externalsecrets/v1/secretstore_device42_types.go`, `apis/externalsecrets/v1/secretstore_types.go`, `apis/externalsecrets/v1/zz_generated.deepcopy.go`	Removes API type definitions for Alibaba and Device42 providers, including AlibabaProvider, AlibabaAuth, Device42Provider, and their related structs. Removes deepcopy methods and updates SecretStoreProvider to eliminate the two provider fields.
CRD Schemas `config/crds/bases/external-secrets.io_clustersecretstores.yaml`, `config/crds/bases/external-secrets.io_secretstores.yaml`, `deploy/crds/bundle.yaml`	Removes Alibaba and Device42 provider schema definitions from CustomResourceDefinitions, eliminating authentication, configuration, and field specifications for both providers across v1 and v1beta1 versions.
Alibaba Provider Implementation `providers/v1/alibaba/client.go`, `providers/v1/alibaba/kms.go`, `providers/v1/alibaba/logger.go`, `providers/v1/alibaba/utils.go`, `providers/v1/alibaba/fake/fake.go`, `providers/v1/alibaba/go.mod`	Removes complete Alibaba Cloud KMS provider implementation including the SecretsManagerClient interface, KeyManagementService type, authentication handlers (RRSA and SecretRef), secret retrieval logic, and test mocking utilities.
Device42 Provider Implementation `providers/v1/device42/device42.go`, `providers/v1/device42/device42_api.go`, `providers/v1/device42/fake/fake.go`, `providers/v1/device42/go.mod`	Removes complete Device42 provider implementation including the Device42 and Client types, HTTP API client with authenticated request handling, secret mapping, and test mocking utilities.
Provider Registration `pkg/register/alibaba.go`, `pkg/register/device42.go`, `go.mod`, `hack/api-docs/mkdocs.yml`	Removes provider registration initialization functions and replaces indirect dependencies in go.mod. Removes navigation entries for both providers from API documentation configuration.
Documentation `docs/api/spec.md`, `docs/introduction/stability-support.md`, `docs/provider/alibaba.md`, `docs/provider/device42.md`, `docs/snippets/device42-external-secret.yaml`	Removes all provider documentation including API specification blocks, stability/support matrix entries, provider integration guides, and example YAML snippets for both Alibaba and Device42.
Tests and Test Infrastructure `e2e/suites/provider/cases/alibaba/alibaba.go`, `e2e/suites/provider/cases/alibaba/provider.go`, `providers/v1/alibaba/kms_test.go`, `providers/v1/device42/device42_api_test.go`, `e2e/go.mod`	Removes end-to-end test suites, unit tests, and test framework setup for both providers. Removes alibaba-cloud-sdk-go and related transitive dependencies from e2e module dependencies.
Test Snapshots `tests/__snapshot__/clustersecretstore-v1.yaml`, `tests/__snapshot__/secretstore-v1.yaml`	Removes Alibaba and Device42 provider blocks from snapshot test fixtures, eliminating example configurations for both providers.

Possibly related PRs

chore: revert remove unmaintained secret stores #5857: Reintroduces the Alibaba and Device42 provider implementations, types, CRD schemas, documentation, and tests that are removed in this PR—directly reverses these changes.
chore: remove unmaintained secret stores #5854: Also removes the Alibaba and Device42 provider implementations and related configuration—modifies the same files and symbols.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

eso-service-account-app · 2026-02-02T18:22:39Z

[Bot] - ✅ e2e for aa0867dab00a5cc2fa4ab1788be28323a02551eb passed

sonarqubecloud · 2026-02-06T11:51:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…2 (#3782) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets/external-secrets](https://github.com/external-secrets/external-secrets) | major | `v1.3.2` → `v2.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets/external-secrets)</summary> ### [`v2.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v2.0.0) [Compare Source](external-secrets/external-secrets@v1.3.2...v2.0.0) ### BREAKING CHANGE Please note that this release removed two of the unsupported and unmaintained providers Alibaba and Device42. Image: `ghcr.io/external-secrets/external-secrets:v2.0.0` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: bump charts to 1.3.2 by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5923](external-secrets/external-secrets#5923) - feat(charts): add hostAliases support by [@janlauber](https://github.com/janlauber) in [#5866](external-secrets/external-secrets#5866) - chore: remove unmaintained secret stores by [@Skarlso](https://github.com/Skarlso) in [#5918](external-secrets/external-secrets#5918) - docs(infisical): document al provider auth methods by [@varonix0](https://github.com/varonix0) in [#5929](external-secrets/external-secrets#5929) - chore: Get validating webhook failurePolicy for Secretstore dynamically by [@LochanRn](https://github.com/LochanRn) in [#5605](external-secrets/external-secrets#5605) #### New Contributors - [@LochanRn](https://github.com/LochanRn) made their first contribution in [#5605](external-secrets/external-secrets#5605) **Full Changelog**: <external-secrets/external-secrets@v1.3.2...v2.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3782 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `1.3.2` → `2.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v2.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v2.0.0) [Compare Source](external-secrets/external-secrets@v1.3.2...v2.0.0) ### BREAKING CHANGE Please note that this release removed two of the unsupported and unmaintained providers Alibaba and Device42. Image: `ghcr.io/external-secrets/external-secrets:v2.0.0` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: bump charts to 1.3.2 by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5923](external-secrets/external-secrets#5923) - feat(charts): add hostAliases support by [@janlauber](https://github.com/janlauber) in [#5866](external-secrets/external-secrets#5866) - chore: remove unmaintained secret stores by [@Skarlso](https://github.com/Skarlso) in [#5918](external-secrets/external-secrets#5918) - docs(infisical): document al provider auth methods by [@varonix0](https://github.com/varonix0) in [#5929](external-secrets/external-secrets#5929) - chore: Get validating webhook failurePolicy for Secretstore dynamically by [@LochanRn](https://github.com/LochanRn) in [#5605](external-secrets/external-secrets#5605) #### New Contributors - [@LochanRn](https://github.com/LochanRn) made their first contribution in [#5605](external-secrets/external-secrets#5605) **Full Changelog**: <external-secrets/external-secrets@v1.3.2...v2.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3788 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Nattapong Ekudomsuk <nuttapong_mos@hotmail.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `1.3.2` → `2.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v2.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v2.0.0) [Compare Source](external-secrets/external-secrets@v1.3.2...v2.0.0) ### BREAKING CHANGE Please note that this release removed two of the unsupported and unmaintained providers Alibaba and Device42. Image: `ghcr.io/external-secrets/external-secrets:v2.0.0` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v2.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: bump charts to 1.3.2 by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5923](external-secrets/external-secrets#5923) - feat(charts): add hostAliases support by [@janlauber](https://github.com/janlauber) in [#5866](external-secrets/external-secrets#5866) - chore: remove unmaintained secret stores by [@Skarlso](https://github.com/Skarlso) in [#5918](external-secrets/external-secrets#5918) - docs(infisical): document al provider auth methods by [@varonix0](https://github.com/varonix0) in [#5929](external-secrets/external-secrets#5929) - chore: Get validating webhook failurePolicy for Secretstore dynamically by [@LochanRn](https://github.com/LochanRn) in [#5605](external-secrets/external-secrets#5605) #### New Contributors - [@LochanRn](https://github.com/LochanRn) made their first contribution in [#5605](external-secrets/external-secrets#5605) **Full Changelog**: <external-secrets/external-secrets@v1.3.2...v2.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/283

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

chore: remove unmaintained secret stores

aa0867d

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

github-project-automation bot added this to External Secrets Feb 2, 2026

github-actions bot added the kind/chore Categorizes Pull Requests for chore activities (like bumping versions) label Feb 2, 2026

github-actions bot added kind/documentation Categorizes issue or PR as related to documentation. kind/dependency dependabot and upgrades size/l labels Feb 2, 2026

Skarlso requested review from IdanAdar, evrardj-roche, gusfcarvalho and moolen February 5, 2026 21:12

gusfcarvalho approved these changes Feb 6, 2026

View reviewed changes

jakobmoellerdev approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'main' into remove-unmaintained-providers-2

1e9d72d

moolen approved these changes Feb 6, 2026

View reviewed changes

Skarlso merged commit c6e1a35 into external-secrets:main Feb 6, 2026
31 checks passed

github-project-automation bot moved this to Done in External Secrets Feb 6, 2026

Skarlso deleted the remove-unmaintained-providers-2 branch February 6, 2026 12:21

This was referenced Feb 11, 2026

feat(charts): add new flag enable leader for cert-manager #5863

Merged

feat(providers): add ovh provider #5830

Closed

WIP - DO NOT REVIEW -Abandonned: Feature registry #5954

Closed

This was referenced Mar 16, 2026

feat: ovh provider implementation #6097

Closed

feat: ovh provider implementation #6101

Merged

feat: support reading values from Kubernetes CRD #6107

Closed

dsp0x4 pushed a commit to dsp0x4/external-secrets that referenced this pull request Mar 22, 2026

chore: remove unmaintained secret stores (external-secrets#5918)

8930bcb

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove unmaintained secret stores#5918

chore: remove unmaintained secret stores#5918
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:remove-unmaintained-providers-2

Skarlso commented Feb 2, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

Skarlso commented Feb 2, 2026

Uh oh!

coderabbitai bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

eso-service-account-app bot commented Feb 2, 2026

Uh oh!

sonarqubecloud bot commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Skarlso commented Feb 2, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Related Issue

Proposed Changes

Format

Checklist

Summary

Uh oh!

Skarlso commented Feb 2, 2026

Uh oh!

coderabbitai bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Uh oh!

eso-service-account-app bot commented Feb 2, 2026

Uh oh!

sonarqubecloud bot commented Feb 6, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Skarlso commented Feb 2, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 2, 2026 •

edited

Loading