Skip to content

fix: lets not use the docker buildx cache#5847

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:ubi-fix-try-2
Jan 20, 2026
Merged

fix: lets not use the docker buildx cache#5847
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:ubi-fix-try-2

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Jan 19, 2026

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Disables Docker buildx cache to ensure clean builds.

Changes:

  • .github/workflows/publish.yml: Adds --no-cache flag to Docker build arguments in both fork and non-fork publishing paths
  • Dockerfile.ubi: Changes tar invocation from -cf to -chf to follow symlinks when archiving files

These modifications prevent cached Docker layers from being reused during builds and ensure symlinks are resolved in the archive.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. component/github-actions size/xs labels Jan 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 19, 2026

Walkthrough

The changes modify Docker build workflow configuration to disable caching and update a tar command in the Dockerfile to follow symlinks during file archival.

Changes

Cohort / File(s) Summary
Docker Build Configuration
.github/workflows/publish.yml
Adds --no-cache flag to DOCKER_BUILD_ARGS in Build & Publish Artifacts paths; fork path modified to --no-cache --load and non-fork path adds --no-cache before --push
Container Image Configuration
Dockerfile.ubi
Changes tar command from -cf to -chf to follow symlinks when constructing archive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit fd2d062 into external-secrets:main Jan 20, 2026
35 checks passed
@Skarlso Skarlso deleted the ubi-fix-try-2 branch January 20, 2026 05:49
dsp0x4 pushed a commit to dsp0x4/external-secrets that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions kind/bug Categorizes issue or PR as related to a bug. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants