Skip to content

fix: ubi build with very VERY old docker buildx version#5846

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:disable-secretservice-tests-for-now
Jan 19, 2026
Merged

fix: ubi build with very VERY old docker buildx version#5846
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:disable-secretservice-tests-for-now

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Jan 19, 2026

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

This PR fixes UBI (Universal Base Image) builds when using very old Docker buildx versions. The changes include:

  1. .github/workflows/publish.yml: Removed the explicit version pin constraint for the docker/setup-buildx-action, allowing the action to use default behavior instead of forcing an old version.

  2. Dockerfile.ubi: Removed the RUN ls -lR / directory listing command that was causing compatibility issues with older buildx versions during the build process.

  3. e2e/suites/provider/cases/secretserver/secretserver.go: Changed the secretserver test suite from Describe to PDescribe to enable parallel test execution.

The primary fix addresses compatibility issues between older Docker buildx versions and certain Dockerfile constructs used in the UBI image builds.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. component/github-actions labels Jan 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 19, 2026

Walkthrough

This pull request removes a version constraint from a GitHub Actions workflow step, eliminates a debug directory listing command from a Docker build file, and converts a test suite from sequential to parallel execution mode using PDescribe.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
\.github/workflows/publish\.yml
Removed explicit version pin (v0.4.2) from docker/setup-buildx-action step; now relies on default behavior.
Docker Build Configuration
Dockerfile\.ubi
Removed debug RUN ls -lR / statement from build process; no functional impact on subsequent commands.
Test Suite Parallelization
e2e/suites/provider/cases/secretserver/secretserver\.go
Changed test suite initializer from Describe to PDescribe to enable parallel test execution.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit 2d3c799 into external-secrets:main Jan 19, 2026
35 checks passed
@Skarlso Skarlso deleted the disable-secretservice-tests-for-now branch January 19, 2026 20:18
dsp0x4 pushed a commit to dsp0x4/external-secrets that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions kind/bug Categorizes issue or PR as related to a bug. size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants