Skip to content

fix: use maps.Equal instead of bytes.Compare for JSON value#5448

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-vault-compare-issue
Oct 10, 2025
Merged

fix: use maps.Equal instead of bytes.Compare for JSON value#5448
Skarlso merged 1 commit intoexternal-secrets:mainfrom
Skarlso:fix-vault-compare-issue

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 10, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #5443

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
@Skarlso Skarlso force-pushed the fix-vault-compare-issue branch from d33fa52 to 4b6441c Compare October 10, 2025 11:11
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. size/s labels Oct 10, 2025
@sonarqubecloud
Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 10, 2025

/ok-to-test sha=4b6441c4fa949413b4b57792f61169e2f89e0730

@Skarlso Skarlso moved this to In Review in External Secrets Oct 10, 2025
@eso-service-account-app
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso merged commit 759093c into external-secrets:main Oct 10, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in External Secrets Oct 10, 2025
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…-secrets#5448)

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/s

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PushSecret updates Vault on every refreshInterval instead of only on Secret changes

2 participants