Skip to content

chore(actions): always run helm test and update make check-diff#5440

Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:always-run-helm-tests
Oct 9, 2025
Merged

chore(actions): always run helm test and update make check-diff#5440
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:always-run-helm-tests

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 9, 2025

Problem Statement

On several occasions we neglect running helm test. We only run it if deployments are changed, but in reality, other things can affect the end result, such es kubebuilder annotations or changes to the API. In those cases we ignore the test runs and that's just bad.

Also, we neglect to run helm.test.update to make sure that changes are reflected in the helm test. So now, check-diff is running helm.test.update and test.crds.update to see if there are any changes that need to be pushed into the helm tests.

Related Issue

Fixes #...

Proposed Changes

How do you like to solve the issue and why?

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

  • charts
  • release
  • testing
  • security
  • templating

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions bot added kind/chore Categorizes Pull Requests for chore activities (like bumping versions) area/actions component/github-actions size/xs labels Oct 9, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2025

@Skarlso Skarlso merged commit 3544c3e into external-secrets:main Oct 9, 2025
30 checks passed
SamuelMolling pushed a commit to SamuelMolling/external-secrets that referenced this pull request Oct 24, 2025
…rnal-secrets#5440)

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/actions component/github-actions kind/chore Categorizes Pull Requests for chore activities (like bumping versions) size/xs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants