chore(actions): always run helm test and update make check-diff#5440
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Oct 9, 2025
Merged
chore(actions): always run helm test and update make check-diff#5440Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
moolen
approved these changes
Oct 9, 2025
|
5 tasks
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…rnal-secrets#5440) Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
On several occasions we neglect running helm test. We only run it if deployments are changed, but in reality, other things can affect the end result, such es kubebuilder annotations or changes to the API. In those cases we ignore the test runs and that's just bad.
Also, we neglect to run helm.test.update to make sure that changes are reflected in the helm test. So now, check-diff is running helm.test.update and test.crds.update to see if there are any changes that need to be pushed into the helm tests.
Related Issue
Fixes #...
Proposed Changes
How do you like to solve the issue and why?
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable