chore(linter): fix revive linter issues in pkg#5412
Merged
moolen merged 5 commits intoexternal-secrets:mainfrom Oct 8, 2025
Merged
chore(linter): fix revive linter issues in pkg#5412moolen merged 5 commits intoexternal-secrets:mainfrom
pkg#5412moolen merged 5 commits intoexternal-secrets:mainfrom
Conversation
pkgpkg
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
* rename the pkg/utils to pkg/esutils Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
de5a449 to
ee54a6c
Compare
moolen
approved these changes
Oct 8, 2025
Member
moolen
left a comment
There was a problem hiding this comment.
LGTM, thanks for going through this painful work ❤️
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
* chore(linter): fix revive linter errors Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> * chore(linter): fix revive linter errors * rename the pkg/utils to pkg/esutils Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> * chore(linter): fix import issues Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> * chore(linter): fix package comment Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> --------- Signed-off-by: Olumide Ogundele <olumideralph@gmail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
According to this PR #3396 was implemented, the revive linter wasn't configured because it had loads of issues to be fixed. This PR configures the revive linter and fixes all the issues raised by the linter.
Related Issue
Fixes #3397
Proposed Changes
Fix all the issues raised by the linter so that we can configure the revive linter. It is the second in the series of PRs to follow.
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable