docs: issue-5350: Updates CRD and docs with write-only limitation for github provider#5361
Merged
moolen merged 2 commits intoexternal-secrets:mainfrom Sep 26, 2025
Merged
Conversation
…b provider Signed-off-by: Bharath B <bhb@redhat.com>
moolen
approved these changes
Sep 26, 2025
|
SamuelMolling
pushed a commit
to SamuelMolling/external-secrets
that referenced
this pull request
Oct 24, 2025
…b provider (external-secrets#5361) Signed-off-by: Bharath B <bhb@redhat.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
GitHub Provider when used as SecretStore or ClusterSecret supports PushSecret only or in an essentially one-way / write-only behavior. However, the documentation doesn't mention it and could lead to confusion.
Related Issue
Fixes #5350
Proposed Changes
Updates the github provider API description and the provider documentation with the limitation.
Checklist
git commit --signoffmake testmake reviewable