chore: bump go, e2e: flux/argo & restructure e2e-bin build#5333
Conversation
c40a9f5 to
e006422
Compare
| openssl | ||
|
|
||
| ENV KUBECTL_VERSION="v1.34.1" | ||
| ENV HELM_VERSION="v3.19.0" |
There was a problem hiding this comment.
intention: instead of building the binaries inside the container, they are built from a Makefile target before the e2e image is built.
This allows us to leverage the go mod/build cache.
There was a problem hiding this comment.
Shouldn't this be a comment in code instead? 0 chances I am gonna find that in 6 months without it being in either comment OR git blame.
| }, | ||
| Spec: v1.ServiceSpec{ | ||
| } | ||
| _, err = controllerutil.CreateOrUpdate(GinkgoT().Context(), s.config.CRClient, svc, func() error { |
There was a problem hiding this comment.
make it idempotent to allow re-running the test without recreating the cluster - in case one ctrl+c out of the test.
evrardjp
left a comment
There was a problem hiding this comment.
I am not familiar enough with the e2e code to review this. I haven't tried it locally. At first glance it does make sense but i have no clue about collateral impact. I will try to test locally.
|
You should be able to run them with |
That's what i imagined... I was sadly thinking about the tough provider way. But unrelated to my first tests so let's ignore that for now. Thanks. |
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
|
I removed all bits related to caching from the PR. I'm not really sure if we should even touch the cache, as setup-go has its own caching mechanism builtin supporting go dependencies as well as build outputs. We could hand-roll the cache handling for |
|
The CI already feels difficult for a newcomer tbh. I welcome the fact to NOT add complexity. I like this better. I still can't test it, I would appreciate some time with you to test locally. |
|
My current setup breaks on trying to run e2e locally, I suppose its a problema here. I did some changes but, still no able to complete it. I'm running on macos arm, lima nerdctl (for docker usage),
It fails on Just mentioning, if anyone have a similar setup. |
This is likely an issue with architecture incompatibility of |
I feel you, the e2e tests are a bit hard to grasp. I guess it would make sense to have a knowledge sharing session on this. |
I need some help on what "IIRC" stands for :) |
iirc it stands for "if i recall correctly" |
jakobmoellerdev
left a comment
There was a problem hiding this comment.
mostly good for me
Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
|
@moolen Something else you need on this? |
|
@Skarlso i think i need an approval :D Feel free to take a look. |
|
…secrets#5333) * chore: bump flux/argo & restructure e2e-bin build Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * remove explicit cache Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * fix: use go-version-file everywhere Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> --------- Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> Signed-off-by: Anpoo Sivanadi <sivanadi08@gmail.com>
…secrets#5333) * chore: bump flux/argo & restructure e2e-bin build Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * remove explicit cache Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * fix: use go-version-file everywhere Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> --------- Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> Signed-off-by: Samuel Molling <samuelmolling@gmail.com>
This PR bumps e2e test components: fluxcd, argocd as well as bumping flux API versions.
I've changed the e2e Dockerfile to allow caching of go modules/build files.
Timings: