chore(deps): bump golang from 1.24.5 to 1.24.6 and helm-values-schema-json plugin to 2.2.1#5126
Conversation
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
|
Added a pin to the HELM schema plugin which introduced some breaking changes for flags and output reformatting (see previous failure in https://github.com/external-secrets/external-secrets/actions/runs/16887655454/job/47839413240) |
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
9936622 to
a152b3e
Compare
|
have to go even further back on helm schema plugin. the current rollback I did failed but just didnt return a non-zero error code so CI passed as a false positive. https://github.com/losisin/helm-values-schema-json/releases/tag/v2.2.1
https://github.com/losisin/helm-values-schema-json/releases/tag/v2.0.0
thus we need to go to 1.9.2 or bump to v2.2.1 EDIT: |
properly bumps helm schema plugin to 2.2.1 and actually uses the correct flags that were previously failing Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
|
Sorry about the breaking changes! Happy to see people are using the plugin though 😅 |
2.2.1
properly bumps helm schema plugin to 2.2.1 and actually uses the correct flags that were previously failing Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
|
|
well the CI gods haunt me, apparently the generator has some different new line settings than my pre commit formatter that caused the diff checker to break :D |
|
Aaaaaand now we have infra breaking on us. This PR is cursed 🤬 :D we will wait for the next run |
moolen
left a comment
There was a problem hiding this comment.
LGTM 🎉 thank you for fixing this ❤️
…-json plugin to `2.2.1` (external-secrets#5126) * chore(deps): bump golang from 1.24.5 to 1.24.6 Signed-off-by: Jakob Möller <jakob.moeller@sap.com> * chore(deps): pin helm schema plugin to v1.9.2 to avoid breaking changes Signed-off-by: Jakob Möller <jakob.moeller@sap.com> * chore(deps): bump helm-schema to v2.2.1 properly bumps helm schema plugin to 2.2.1 and actually uses the correct flags that were previously failing Signed-off-by: Jakob Möller <jakob.moeller@sap.com> * chore(deps): bump helm-schema to v2.2.1 properly bumps helm schema plugin to 2.2.1 and actually uses the correct flags that were previously failing Signed-off-by: Jakob Möller <jakob.moeller@sap.com> --------- Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Problem Statement
What is the problem you're trying to solve?
Bumping Go to remediate Trivy finding
Related Issue
Bumps go to 1.24.6 manually to resolve Trivy finding blocking CI https://github.com/external-secrets/external-secrets/actions/runs/16884393908/job/47828242767
Proposed Changes
How do you like to solve the issue and why?
Do the same as #5117 but also bump go runtime
Checklist
git commit --signoffmake testmake reviewable