feat(helm): check for ServiceMonitor GVK#5059
Closed
l0wl3vel wants to merge 5 commits intoexternal-secrets:mainfrom
Closed
feat(helm): check for ServiceMonitor GVK#5059l0wl3vel wants to merge 5 commits intoexternal-secrets:mainfrom
l0wl3vel wants to merge 5 commits intoexternal-secrets:mainfrom
Conversation
instead of only GV monitoring.coreos.com/v1 Fixes external-secrets#5058 Signed-off-by: Benjamin Ritter <benjamin.ritter@stackit.cloud>
a74a3c9 to
1653ea1
Compare
due to missing CRDS Signed-off-by: Benjamin Ritter <benjamin.ritter@stackit.cloud>
Co-authored-by: Gustavo Fernandes de Carvalho <17139678+gusfcarvalho@users.noreply.github.com> Signed-off-by: Benjamin Ritter <7373184+l0wl3vel@users.noreply.github.com>
gusfcarvalho
approved these changes
Aug 5, 2025
5 tasks
|
Contributor
|
@gusfcarvalho I think this needs a quick rebase / retrigger |
Member
Author
|
Yes, that feature is what we were looking for. I will close this MR and my Issue. Thank you for the help. |
Member
|
thanks for your contribution as well! I know it got hammered into one, but we really appreciate it all!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Prevents unexpected rendering failure if any monitoring.coreos.com/v1 CRD is installed, while the ServiceMonitor CRD is missing.
Related Issue
Fixes #5058
Proposed Changes
Instead of checking if any CRD in the monitoring.coreos.com/v1 GV is available, like we do now, we check if the used CRD, ServiceMonitor, is installed.
Checklist
git commit --signoffmake testmake reviewable