feat: allow setting namespace on bitwarden-sdk-server subchart#4982
Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom Jul 3, 2025
Merged
feat: allow setting namespace on bitwarden-sdk-server subchart#4982Skarlso merged 3 commits intoexternal-secrets:mainfrom
Skarlso merged 3 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Martin Tome <mrtn.tome@gmail.com>
Contributor
|
Interesting how the unit test fails, but didn't fail for the Pr that actually introduced this change. :/ |
Contributor
|
Please run |
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
approved these changes
Jul 3, 2025
|
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
…nal-secrets#4982) * feat: allow setting namespace on bitwarden-sdk-server subchart Signed-off-by: Martin Tome <mrtn.tome@gmail.com> * fix: run make helm test update Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> --------- Signed-off-by: Martin Tome <mrtn.tome@gmail.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Allows setting the namespace of bitwarden-sdk-server subchart manifests, following release.namespace or overriding with helm value. (see related PR)
Related Issue
No related Issues.
Proposed Changes
Use last release of subchart that allows setting namespace, add value to values.yaml and values schema.
Checklist
git commit --signoffmake testmake reviewable