Update full-cluster-secret-store example to reference secret namespaces#4964
Update full-cluster-secret-store example to reference secret namespaces#4964Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
The example as written doesn't work if you're trying to create an external secret in any namespace other than the one with your AWS access key secrets in it. We should specify the namespace of the secrets in the ClusterSecretStore example so that it actually works for people following along when creating ExternalSecrets in another namespace that reference the cluster-wide store. Signed-off-by: Jaz <ericvolp12@gmail.com>
|
This won't work if it's being use by an external secret that is NOT in that namespace. That is why it's left empty. Normally, the namespace would be used that is the namespace of the referencing object. What was your error? I assume your error was that you created a secret in a different namespace than the external secret that was referencing this ClusterSecretStore? I cannot accept this PR as is, but if you would like to add a NOTE in the documentation using this, I'll accept that. :) |
|
The If you put the AWS credentials for your If, however, you specify the The point here is that a |
|
Ah, sorry, I think AWS is a bit special. This results in referrent auth I believe. We really should bring together how everything works. Sometimes this isn't allowed. But AWS does allow it. :D argh. |
|
Ah nevermind. I think I found the right code. This will never be not confusing. :D |
|
|
Awesome, thanks! |
…es (external-secrets#4964) The example as written doesn't work if you're trying to create an external secret in any namespace other than the one with your AWS access key secrets in it. We should specify the namespace of the secrets in the ClusterSecretStore example so that it actually works for people following along when creating ExternalSecrets in another namespace that reference the cluster-wide store. Signed-off-by: Jaz <ericvolp12@gmail.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
Problem Statement
What is the problem you're trying to solve?
The example as written doesn't work if you're trying to create an external secret in any namespace other than the one with your AWS access key secrets in it. We should specify the namespace of the secrets in the ClusterSecretStore example so that it actually works for people following along when creating ExternalSecrets in another namespace that reference the cluster-wide store.
Related Issue
Fixes #...
Proposed Changes
How do you like to solve the issue and why?
Enhancing the docs to include the
namespacefield in secret ref examples for an ExternalSecretStoreChecklist
git commit --signoffmake testmake reviewable