Skip to content

fix: group variables not taking account of environments#4928

Merged
Skarlso merged 1 commit intomainfrom
gc/fix/gitlab-env-not-added-in-group
Jun 16, 2025
Merged

fix: group variables not taking account of environments#4928
Skarlso merged 1 commit intomainfrom
gc/fix/gitlab-env-not-added-in-group

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Member

@gusfcarvalho gusfcarvalho commented Jun 16, 2025

Problem Statement

Gitlab Group Variables call was not taking environment filtering.

Related Issue

Fixes #3379

Proposed Changes

Implements environment filtering on gitlab group call

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
@gusfcarvalho gusfcarvalho requested a review from a team as a code owner June 16, 2025 14:54
@gusfcarvalho gusfcarvalho requested a review from knelasevero June 16, 2025 14:54
@sonarqubecloud
Copy link
Copy Markdown

@Skarlso Skarlso merged commit 904e6a6 into main Jun 16, 2025
21 of 22 checks passed
@Skarlso Skarlso deleted the gc/fix/gitlab-env-not-added-in-group branch June 16, 2025 17:07
@fprado
Copy link
Copy Markdown

fprado commented Jun 17, 2025

In which version will this fix be available? Thank you.

@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Jun 17, 2025

It has not been released yet. It will be in 0.18.0.

alliseeisgold pushed a commit to alliseeisgold/external-secrets that referenced this pull request Jul 10, 2025
…rets#4928)

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't retrieve secrets when working with Gitlab variables at group level defined for different environments

3 participants