docs: enhance the example of PushSecret/ClusterPushSecret#4872
Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom Jun 6, 2025
Merged
docs: enhance the example of PushSecret/ClusterPushSecret#4872Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Conversation
df78f27 to
3891708
Compare
Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
3891708 to
6c12046
Compare
Skarlso
approved these changes
Jun 6, 2025
|
pepordev
pushed a commit
to pepordev/external-secrets
that referenced
this pull request
Jun 11, 2025
…ecrets#4872) Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
…ecrets#4872) Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
This PR fixes a couple of issues related to the docs of PushSecret and ClusterPushSecret:
indexfunction is used.PushSecretas it doesn't follow the same structure as the other pages under the same section.Related Issue
Maybe not directly related, but Google sends people to this issue #3443, and with the unfunctional example, the users could think it's related to that bug.
Proposed Changes
Make it easier and more intuitive to use PushSecret/ClusterPushSecret.
Checklist
git commit --signoffmake testmake reviewable