Skip to content

fix: add mutex for thread safety in ProviderOnePassword methods#4839

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
bo0tzz:fix/onepassword-mutex
Jun 2, 2025
Merged

fix: add mutex for thread safety in ProviderOnePassword methods#4839
Skarlso merged 1 commit intoexternal-secrets:mainfrom
bo0tzz:fix/onepassword-mutex

Conversation

@bo0tzz
Copy link
Copy Markdown
Contributor

@bo0tzz bo0tzz commented May 26, 2025

Related Issue

Fixes #4663

Proposed Changes

Use a mutex on every access operation in the onepassword provider.

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

I have not (yet) tested these changes manually.

@bo0tzz bo0tzz marked this pull request as ready for review June 2, 2025 11:50
@bo0tzz bo0tzz requested a review from a team as a code owner June 2, 2025 11:50
@bo0tzz bo0tzz requested a review from knelasevero June 2, 2025 11:50
@bo0tzz bo0tzz force-pushed the fix/onepassword-mutex branch from a8edb49 to f72393a Compare June 2, 2025 11:51
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 2, 2025

@Skarlso Skarlso merged commit 5790350 into external-secrets:main Jun 2, 2025
20 checks passed
@bo0tzz bo0tzz deleted the fix/onepassword-mutex branch June 2, 2025 17:46
pepordev pushed a commit to pepordev/external-secrets that referenced this pull request Jun 11, 2025
…rnal-secrets#4839)

Signed-off-by: bo0tzz <git@bo0tzz.me>
Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1password provider tries to read wrong vault

2 participants