Skip to content

fix: set klog to logger for client-go#4818

Merged
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:set-klogger-for-client-go
May 27, 2025
Merged

fix: set klog to logger for client-go#4818
Skarlso merged 2 commits intoexternal-secrets:mainfrom
Skarlso:set-klogger-for-client-go

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented May 21, 2025

Problem Statement

What is the problem you're trying to solve?

Related Issue

Fixes #4817

Proposed Changes

How do you like to solve the issue and why?

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@Skarlso Skarlso requested a review from a team as a code owner May 21, 2025 13:23
@Skarlso Skarlso requested a review from knelasevero May 21, 2025 13:23
@gusfcarvalho
Copy link
Copy Markdown
Member

gusfcarvalho commented May 21, 2025

missing go mod tidy 🙈

@Skarlso
fix: set klog to logger for client-go
a4df504 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the set-klogger-for-client-go branch from 57db308 to a4df504 Compare May 22, 2025 05:59
@Skarlso Skarlso requested a review from gusfcarvalho May 22, 2025 06:02
@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented May 22, 2025 •
edited
Loading

@gusfcarvalho Yah, sorry. :D I created it then forgot about it :D

@Skarlso Skarlso merged commit 031fb75 into external-secrets:main May 27, 2025
5 checks passed
@Skarlso Skarlso deleted the set-klogger-for-client-go branch May 27, 2025 10:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pepordev pushed a commit to pepordev/external-secrets that referenced this pull request Jun 11, 2025
@Skarlso @pepordev
fix: set klog to logger for client-go (external-secrets#4818)
d79c1e0 
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Pedro Parra Ortega <pedro.parraortega@enreach.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gusfcarvalho gusfcarvalho gusfcarvalho approved these changes

@knelasevero knelasevero Awaiting requested review from knelasevero knelasevero was automatically assigned from external-secrets/maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some shutdown logs are not in JSON format

2 participants

@Skarlso @gusfcarvalho