fix: disable ClusterPushSecret reconciler when using scoped RBAC in helm chart#4571
Merged
gusfcarvalho merged 2 commits intoexternal-secrets:mainfrom Mar 20, 2025
Conversation
Signed-off-by: Albert Llop <mrsimo@gmail.com>
gusfcarvalho
approved these changes
Mar 20, 2025
Member
|
Hi @mrsimo ! thanks for your contribution 💪 🥳 Just waiting for tests to pass in order to 📦 it |
Contributor
Author
|
Cool! Thank you @gusfcarvalho!! |
|
ivankatliarchuk
added a commit
to gofogo/external-secrets-fork
that referenced
this pull request
Mar 20, 2025
* main: Clarify that setting `spec.refreshInterval` to 0 disables all update behaviour (external-secrets#4567) Helm: disable ClusterPushSecret reconciler when using scoped RBAC (external-secrets#4571) Exclude unused resources from rbac (external-secrets#4572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The new
ClusterPushSecretrequires cluster-wide RBAC permissions to run. The Helm chart doesn't disable it when using namespaced / scoped RBAC. The way it's implemented it doesn't disable it when passingprocessClusterPushSecreteither.Related Issue
Didn't create an issue because it seemed a straightforward change.
Proposed Changes
Disable
ClusterPushSecretby default when using scoped RBAC.Checklist
git commit --signoffmake testmake reviewable