feat(aws): support for aws tags#4538
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Thanks for doing this. Do you require me to look at it, or are you still working on things here? :) |
|
I will be working on it thanks. Trying to better understand the setup. |
* main: chore: update helm charts to v0.15.0 (external-secrets#4566) feat: cluster push secret with pushing all secrets from a namespace (external-secrets#4162) fix: check if secret is being deleted during fetch (external-secrets#4562) feat: add cloud.ru secret manager support (external-secrets#3716) update dependencies (external-secrets#4556) feat: non standard templating delimiters (external-secrets#4558) chore(deps): bump distroless/static from `3f2b64e` to `95ea148` (external-secrets#4554) Fix Grafana generator not passing desired SA role to creation request (external-secrets#4533) fix: define top level permissions and fix token scope (external-secrets#4543) chore(deps): bump ubi8/ubi from `ecbeb81` to `5993454` (external-secrets#4553) fix: skip none-existing keys (external-secrets#4517) chore(deps): bump golangci/golangci-lint-action from 6.5.0 to 6.5.1 (external-secrets#4552) chore(deps): bump docker/login-action from 3.3.0 to 3.4.0 (external-secrets#4551) chore(deps): bump aquasecurity/trivy-action from 0.29.0 to 0.30.0 (external-secrets#4550) chore(deps): bump mkdocs-material from 9.6.7 to 9.6.8 in /hack/api-docs (external-secrets#4555) Update full-pushsecret.yaml (external-secrets#4547) feat: add metadata setting to encode secrets as decoded values (external-secrets#4535) feat: introduce codeql scan for code sections (external-secrets#4198) Improve Grafana generator integration with in-cluster Grafana (external-secrets#4519)
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
* main: Clarify that setting `spec.refreshInterval` to 0 disables all update behaviour (external-secrets#4567) Helm: disable ClusterPushSecret reconciler when using scoped RBAC (external-secrets#4571) Exclude unused resources from rbac (external-secrets#4572)
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
* main: update dependencies (external-secrets#4589) chore(deps): bump fossas/fossa-action from 1.5.0 to 1.6.0 (external-secrets#4586) chore(deps): bump mkdocs-material from 9.6.8 to 9.6.9 in /hack/api-docs (external-secrets#4588) chore(deps): bump platformdirs from 4.3.6 to 4.3.7 in /hack/api-docs (external-secrets#4587) chore(deps): bump github/codeql-action from 3.28.11 to 3.28.12 (external-secrets#4585) chore(deps): bump actions/setup-go from 5.3.0 to 5.4.0 (external-secrets#4584) chore(deps): bump golangci/golangci-lint-action from 6.5.1 to 6.5.2 (external-secrets#4583) chore(deps): bump actions/cache from 4.2.2 to 4.2.3 (external-secrets#4582) chore(deps): bump ubi8/ubi from `5993454` to `8bd1b63` (external-secrets#4581) Lookup cluster identity from instance metadata (external-secrets#4575) adding conjur description (external-secrets#4578) fix: bump jwt for cve fix (external-secrets#4580) Add `webhook.create: false` warning comment (external-secrets#4579)
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
Hi @Skarlso . So it looks like I need some help with unit testing. Basically I not fully understand the framework. Example tests I would like to have, but not sure how to.
|
|
I'll take a look. :) |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
@ivankatliarchuk Need anything else with the tests? Or is this now ready to be reviewed? :) |
|
Is ready to an extend. Pls review |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Skarlso
left a comment
There was a problem hiding this comment.
Looks good to me just one tiny comment.
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
|
/ok-to-test sha=df3730b5a80092a35082fe5efd6c86c06e6baf7d |
|
@ivankatliarchuk Hello. If you update your branch this is ready to merge. :) |
|
done |
|



Problem Statement
What is the problem you're trying to solve?
Related Issue
Partially resolves #1821 . Provides a capability to create secrets with KSM key, Description and Tags.
It does not:
Proposed Changes
How do you like to solve the issue and why?
Added support to create a secret with
very similar to
external-secrets/pkg/provider/aws/parameterstore/parameterstore.go
Line 583 in 63740fc
There going to be a breaking change, as before it was
now
It is possible to support both, with slightly more code complexity. My understanding, from reading design docs https://github.com/external-secrets/external-secrets/blob/main/design/010-pushsecret-metadata.md
v1alpha1should support both, or we need to bump version of the API?This PR only covers new secret creation. To support secrets that already managed with secrets operator, I'm planning to open a second pull request. As the code is slightly more complex.
In follow-up I'll have a look how easy is to support Secrets resources policies and region replications.
Tested in the account. Manifests below
Secret is created with Tags, Description, and user specieif kmsKeyID
Checklist
git commit --signoffmake testmake reviewableTest with CLI